fix(just): run the live integration tests one at a time - #733
Merged
Merged
Conversation
`just test-integration` ran the ignored live suites in parallel, but several share fixture databases (backup_dump, restore_file, ddl_pool_safety, paging_offset each drop and reseed their own), so parallel tests collided on them and the command failed on a healthy tree. The release gate in release.yml already passes --test-threads=1; the local command had drifted from it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019uLE7rJcohc7WDPstJ7yCL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
just test-integrationfailed on a healthy tree. It ran the#[ignore]d live suites in parallel, but several of them share fixture databases:backup_dump,restore_file,ddl_pool_safetyandpaging_offseteach drop and reseed their own. Parallel tests collide on those databases ("database exists" from a concurrentCREATE, tables vanishing mid-dump). On both servers, 6 test files had failures in a parallel run.The release gate in
release.ymlalready runs the same suites with--test-threads=1and passes. Only the local command had drifted from it.Change
Adds
--test-threads=1tojust test-integration, with a comment explaining why. The justfile is the only file changed.Verification
just test-integrationon MySQL 8.0 and MariaDB 11: all 18 test binaries pass on both. Before the change, the same command failed inbackup_dump,restore_file,ddl_pool_safety,paging_offset,query_timeoutandintegration_tests.just --fmt --checkpasses.🤖 Generated with Claude Code
https://claude.ai/code/session_019uLE7rJcohc7WDPstJ7yCL
Generated by Claude Code