Skip to content

ENG-2320 Use core Obsidian components for the node type template setting - #1483

Draft
jsmorabito wants to merge 2 commits into
mainfrom
eng-2320-use-core-obsidian-components-for-the-node-type-template
Draft

jsmorabito wants to merge 2 commits into
mainfrom
eng-2320-use-core-obsidian-components-for-the-node-type-template

Conversation

@jsmorabito

@jsmorabito jsmorabito commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

https://entire.io/gh/DiscourseGraphs/discourse-graph/trails/23

Reviewer brief

  • Review focus: DropdownComponent and ExtraButtonComponent are mounted once in a useEffect and then updated from props in separate effects, so React re-renders don't rebuild or duplicate them.
  • Risk or follow-up: Obsidian's searchable "No file selected" file picker is only available to plugins through declarative settings (1.13+). Migrating all settings to declarative settings is tracked in PRO-221.

Verification

  • pnpm ci:validate passes.
  • Manual testing in Obsidian and before/after screenshots are still outstanding.

Loom video

  • TODO: Loom walkthrough with before/after screenshots.

Scope check

  • Ran $scope-check against ENG-2320 and the final diff.
  • Scope beyond Done When: None.

Standards check

  • Ran $dg-pr-adherence-check against the final diff and PR metadata.

Local delegated full review

  • Ran a comprehensive review of the entire final diff in a subagent with a fresh context. Use $dg-delegated-full-review when no other full-review workflow is available.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
discourse-graph Skipped Skipped Sep 24, 2026 7:02pm UTC

Request Review

@supabase

supabase Bot commented Sep 24, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@linear-code

linear-code Bot commented Sep 24, 2026

Copy link
Copy Markdown

ENG-2320

…he node type is imported

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch was previously deployed

1 inactive deployment
Preview — e3220df2 Deployed Sep 24, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant