Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
maparent
force-pushed
the
eng-2202-reconcile-roam-node-schema-metadata-between-sync-and-publish
branch
from
September 21, 2026 16:26
8695ac7 to
4bd3261
Compare
maparent
force-pushed
the
eng-2202-reconcile-roam-node-schema-metadata-between-sync-and-publish
branch
from
September 22, 2026 13:16
4bd3261 to
38b39cd
Compare
maparent
force-pushed
the
eng-2202-reconcile-roam-node-schema-metadata-between-sync-and-publish
branch
from
September 23, 2026 17:48
38b39cd to
fd2cb15
Compare
Entire-Checkpoint: 01M327E9K9BPPZ1R8T0PTZ1KX7
maparent
force-pushed
the
eng-2202-reconcile-roam-node-schema-metadata-between-sync-and-publish
branch
from
September 24, 2026 14:22
fd2cb15 to
a51f9af
Compare
3 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://entire.io/gh/DiscourseGraphs/discourse-graph/trails/10
Reviewer brief
Fairly straightforward changes. templateToText was extracted. A spurious decomposition of DiscourseGraph.text into slashes was removed.
Verification
https://www.loom.com/share/6f58a1f6b2d2447589eb978d8881f366
Loom video
Forthcoming
Scope check
$scope-checkagainst the ENG ticket and final diff.Done When: NoneI decided that integration tests would add too much scope, and that a loom check would be enough. Can revisit.
Local delegated full review
$dg-delegated-full-reviewwhen no other full-review workflow is available.https://linear.app/discourse-graphs/issue/ENG-2202/reconcile-roam-node-schema-metadata-between-sync-and-publish