improve auth gateway config generation - #1559
Open
davehadley wants to merge 4 commits into
Open
Conversation
davehadley
force-pushed
the
drh/improve-auth-gateway-config-generation
branch
from
August 24, 2026 11:53
2b68836 to
88e019f
Compare
davehadley
marked this pull request as ready for review
August 24, 2026 13:05
davehadley
requested review from
JamesDoingStuff,
TBThomas56,
hazdl and
iamvigneshwars
August 24, 2026 13:07
TBThomas56
reviewed
Aug 24, 2026
TBThomas56
reviewed
Aug 24, 2026
davehadley
force-pushed
the
drh/improve-auth-gateway-config-generation
branch
from
August 24, 2026 14:36
88e019f to
a48b098
Compare
TBThomas56
reviewed
Aug 25, 2026
| spec: | ||
| evaluation: | ||
| synchronize: | ||
| enabled: false |
Contributor
There was a problem hiding this comment.
any reason why this is turned off? If a secret is deleted, do we want it to match accordingly?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
working towards: https://jira.diamond.ac.uk/browse/AP-1248
refactors auth gateway config to match method used by auth-broker (see: https://github.com/DiamondLightSource/workflows/blob/main/charts/auth-broker/values.yaml, https://github.com/DiamondLightSource/workflows/blob/main/charts/auth-broker/templates/configpolicy.yaml)