Typography Docs: Expanded MUI Typography Story to include the full DS Typography - #279
Open
zoharma wants to merge 3 commits into
Open
Typography Docs: Expanded MUI Typography Story to include the full DS Typography#279zoharma wants to merge 3 commits into
zoharma wants to merge 3 commits into
Conversation
VictoriaBeilsten-Edmands
requested changes
Aug 14, 2026
VictoriaBeilsten-Edmands
left a comment
VictoriaBeilsten-Edmands
left a comment
Collaborator
There was a problem hiding this comment.
Stories look good.
Can you fix the typo in the commit message?
Document each DiamondDS typography variant and colour option. Updated colour to a more robust guide, and added the full list of typography colours to the Color dropdown.
zoharma
force-pushed
the
zma/show-typography-story
branch
from
August 14, 2026 13:37
e4c1e7a to
963a224
Compare
Collaborator
|
Is it worth a comment when comparing the different typography sizes/types that some are using Outfit and some Inter? |
Contributor
Author
I replaced I also reordered the stories so I've done the other changes requested and made a comment on the width. |
Requested fixes: Remove redundant colour-guide labels, simplify deduping, and update the Storybook render. Updates: Replace `TextSizes` with a `Size ramp` story grouped by rendered pixel size. Reorder stories so `Variant guide` and `Colour guide` appear first, followed by `Alignment`. Prettier fix
zoharma
force-pushed
the
zma/show-typography-story
branch
from
August 14, 2026 14:22
00d215e to
776f684
Compare
VictoriaBeilsten-Edmands
requested changes
Aug 24, 2026
zoharma
force-pushed
the
zma/show-typography-story
branch
from
August 24, 2026 17:00
d911e0d to
eb06752
Compare
zoharma
force-pushed
the
zma/show-typography-story
branch
from
August 24, 2026 17:03
eb06752 to
72f1621
Compare
Contributor
Author
|
@VictoriaBeilsten-Edmands Removed |
zoharma
added
documentation
zoharma
changed the title
zoharma
changed the title
VictoriaBeilsten-Edmands
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #277.
Document each DiamondDS typography variant and colour option. Updated colour to a more robust guide, and added the full list of typography colours to the Color dropdown.