Skip to content

test(agent-identity): rename validUntil to validTo - #2160

Merged
Benoît Cortier (CBenoit) merged 1 commit into
masterfrom
claude/busy-shamir-020843
Oct 27, 2026
Merged

Benoît Cortier (CBenoit) merged 1 commit into
masterfrom
claude/busy-shamir-020843

Conversation

@CBenoit

Copy link
Copy Markdown
Member

DVLS names the bounds of a range <x>From and <x>To, so the validity window of a certificate and of a root is validFrom and validTo.
The mock authority and the conformance suite replicate that API and follow the rename on the wire, in the mock's README, and in the Rust field that the camelCase derive maps to the wire name.

DVLS renames the same field in Devolutions/RDM#20016, and the two changes should merge together.

Issue: DGW-478

🤖 Generated with Claude Code

DVLS names the bounds of a range `<x>From` and `<x>To`, so the validity
window of a certificate and of a root is `validFrom` and `validTo`.
The mock authority and the conformance suite replicate that API and
follow the rename on the wire, in the mock's README, and in the Rust
field that the camelCase derive maps to the wire name.

DVLS renames the same field in Devolutions/RDM#20016, and the two
changes should merge together.

Issue: DGW-478

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@CBenoit

Copy link
Copy Markdown
Member Author

Lines changed (18 added, 18 removed):

Area Added Removed
Production code (ships to users) 0 0
Test code and tooling: agent-identity-mock and agent-identity-conformance sources and unit tests 15 15
Other files: mock README 3 3

Verification on this commit (Windows):

  • git grep validUntil returns nothing; the PEDM ValidUntil policy metadata in agent-policy-tester and now-package-broker is a different, unrelated field and is untouched.
  • RootSummary in dvls.rs reached the wire name through rename_all = "camelCase" on valid_until, so a grep for validUntil does not find it; the field is now valid_to.
  • cargo clippy -p agent-identity-mock -p agent-identity-conformance --all-targets -- -D warnings and cargo +nightly fmt --check are clean.
  • cargo test -p agent-identity-mock -p agent-identity-conformance: 547 pass across the test binaries, 1 ignored, 0 fail.
  • The conformance suite against two mocks with the file backend: PASS 188, FAIL 0, SKIP 1 (a_key_non_exportable needs the Windows software provider and an elevated shell), N/A 2.
  • The testsuite agent_identity::conformance test was not green here: it uses the Windows software provider, whose 28 tests skipped without elevation, and a skip counts as incomplete.
    It reported no failing test.

No intent or contract file in this repository names validUntil, so none needed a change.

RDM CI: I found no workflow in the RDM branch of Devolutions/RDM#20016 that builds or runs agent-identity-conformance, or that pins a Gateway revision for it.
The only Agent Identity job there is a database-migration job.
The search covered the workflow files on that branch only, so a pipeline outside .github/workflows would not show up.

Note

LLM-assisted content (no human feedback).

@CBenoit
Benoît Cortier (CBenoit) merged commit f57d634 into master Oct 27, 2026
54 checks passed
@CBenoit
Benoît Cortier (CBenoit) deleted the claude/busy-shamir-020843 branch October 27, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant