Skip to content

chore: fix false positive npm-ci check - #64

Merged
IlyaKhD merged 1 commit into
mainfrom
khd/fix-false-positive-npm-ci-check
Aug 20, 2026
Merged

chore: fix false positive npm-ci check#64
IlyaKhD merged 1 commit into
mainfrom
khd/fix-false-positive-npm-ci-check

Conversation

@IlyaKhD

@IlyaKhD IlyaKhD commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Practical Value

Should fix this: https://github.com/DevExpress/jssecurity/actions/runs/32314092084

Before

After

Copilot AI lite review requested due to automatic review settings August 20, 2026 05:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the lockfile allowlist used by the code-scanning package’s lockfile validation logic, likely to avoid triggering an external CI check via keyword matches in source comments.

Changes:

  • Removed inline “// npm/yarn/pnpm/bun” comments from the LOCK_FILES constant in validate-lock-files.ts.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@IlyaKhD
IlyaKhD merged commit 8304013 into main Aug 20, 2026
1 check passed
@IlyaKhD
IlyaKhD deleted the khd/fix-false-positive-npm-ci-check branch August 20, 2026 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants