Map: OSM provider — Define the public API contract - #34858
Open
AlisherAmonulloev wants to merge 5 commits into
Open
Map: OSM provider — Define the public API contract#34858AlisherAmonulloev wants to merge 5 commits into
AlisherAmonulloev wants to merge 5 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Defines the OSM map provider’s public geocoding and routing callback contract across core typings and framework wrappers.
Changes:
- Adds OSM location and route callback types.
- Exposes callbacks through
providerConfig. - Adds corresponding warnings and wrapper bindings.
Reviewed changes
Copilot reviewed 7 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
packages/devextreme/ts/dx.all.d.ts |
Adds bundled OSM API declarations. |
packages/devextreme/js/ui/widget/ui.errors.js |
Documents new warning identifiers. |
packages/devextreme/js/ui/map.d.ts |
Defines OSM callback types and options. |
packages/devextreme/js/ui/map_types.d.ts |
Re-exports new public types. |
packages/devextreme/js/__internal/ui/errors.ts |
Adds missing-callback warnings. |
packages/devextreme-vue/src/map.ts |
Adds Vue callback props and events. |
packages/devextreme-react/src/map.ts |
Adds React callback props. |
packages/devextreme-angular/src/ui/nested/provider-config.ts |
Adds generic Angular nested inputs. |
packages/devextreme-angular/src/ui/map/nested/provider-config.ts |
Adds typed Angular map inputs. |
packages/devextreme-angular/src/ui/map/index.ts |
Extends Angular map configuration types. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.