Scheduler: fix resize of all day appointment in timeline views and vertical views - #34855
Open
sjbur wants to merge 2 commits into
Open
Scheduler: fix resize of all day appointment in timeline views and vertical views#34855sjbur wants to merge 2 commits into
sjbur wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Scheduler all-day appointment resizing across timeline and vertical views.
Changes:
- Adjusts all-day date expansion by view type.
- Uses view-specific all-day panel options during resizing.
- Updates resizing logic and related tests.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
expand_all_day.ts |
Changes regular-panel date expansion. |
expand_all_day.test.ts |
Tests view-specific expansion behavior. |
generate_grid_view_model.ts |
Passes timeline context to expansion. |
m_subscribes.ts |
Uses current-view all-day panel mode. |
m_core.ts |
Refines occupied-day cell handling. |
get_delta_time.test.ts |
Corrects resize test description. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+83
to
+85
| if (!isTimelineView && entity.endDateUTC > entity.startDateUTC) { | ||
| return entity; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
I am not sure that this comment is valid. I verified fix behavior and everything looks as intented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.