Skip to content

add type test for @keyword() decorator (with unnecessary parentheses) with a context manager #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DetachHead merged 1 commit into from
Oct 13, 2026
Merged

add type test for @keyword() decorator (with unnecessary parentheses) with a context manager #390

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 20 additions & 12 deletions tests/type_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,47 +23,55 @@ def a() -> None: ...

# keyword, no args:
@keyword
def g() -> None: ...
def b() -> None: ...

_ = assert_type(g, Callable[[], None]) # ty:ignore[type-assertion-failure]
_ = assert_type(b, Callable[[], None]) # ty:ignore[type-assertion-failure]

# keyword, no args, returns Never:
@keyword # make sure there's no deprecation warning here
def h() -> Never:
def c() -> Never:
raise Exception

_ = assert_type(h, Callable[[], Never]) # ty:ignore[type-assertion-failure]
_ = assert_type(c, Callable[[], Never]) # ty:ignore[type-assertion-failure]

# keyword, wrap_context_manager=True:
@keyword(wrap_context_manager=True)
@contextmanager
def b() -> Generator[None, None, None]:
def d() -> Generator[None, None, None]:
yield

_ = assert_type(b, Callable[[], AbstractContextManager[None]]) # ty:ignore[type-assertion-failure]
_ = assert_type(d, Callable[[], AbstractContextManager[None]]) # ty:ignore[type-assertion-failure]

# keyword, wrap_context_manager=False:
@keyword(wrap_context_manager=False)
@contextmanager
def c() -> Generator[None, None, None]:
def e() -> Generator[None, None, None]:
yield

_ = assert_type(c, Callable[[], _GeneratorContextManager[None]]) # ty:ignore[type-assertion-failure]
_ = assert_type(e, Callable[[], _GeneratorContextManager[None]]) # ty:ignore[type-assertion-failure]

# keyword, context manager with no wrap_context_manager arg:
@keyword # pyright:ignore[reportDeprecated] # ty: ignore[deprecated] # pyrefly: ignore[deprecated]
@contextmanager
def d() -> Generator[None, None, None]:
def f() -> Generator[None, None, None]:
yield

_ = assert_type(f, Never)

# pyright doesn't report an error here due to https://github.com/microsoft/pyright/issues/11292
@keyword() # ty: ignore[deprecated] # pyrefly: ignore[deprecated]
@contextmanager
def g() -> Generator[None]:
yield

_ = assert_type(d, Never)
_ = assert_type(g, Never)

# keyword, non-context manager with wrap_context_manager=True:
# expected type error
@keyword(wrap_context_manager=True) # pyright:ignore[reportArgumentType] # ty:ignore[invalid-argument-type] # pyrefly: ignore[bad-argument-type]
def e() -> None: ...
def h() -> None: ...

# keyword, non-context manager with wrap_context_manager=False:
# expected type error
@keyword(wrap_context_manager=False) # pyright:ignore[reportArgumentType] # ty:ignore[invalid-argument-type] # pyrefly: ignore[bad-specialization]
def f() -> None: ...
def i() -> None: ...
Loading