Skip to content

Issue 1934: Add missing docker login config to weekly tests - #1935

Open
JoerivanEngelen wants to merge 1 commit into
masterfrom
fix_weekly
Open

JoerivanEngelen wants to merge 1 commit into
masterfrom
fix_weekly

Conversation

@JoerivanEngelen

Copy link
Copy Markdown
Contributor

Fixes #1934

Description

Fix broken weekly tests that have been broken for a while now, because of some missing docker login config in the Kotlin file.

Checklist

  • Links to correct issue
  • Update changelog, if changes affect users
  • PR title starts with Issue #nr, e.g. Issue #737
  • Unit tests were added
  • If feature added: Added/extended example
  • If feature added: Added feature to API documentation
  • If pixi.lock was changed: Ran pixi run generate-sbom and committed changes

@sonarqubecloud

Copy link
Copy Markdown

@LuukBlom LuukBlom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, havent seen these docker configs before, so not sure about this, but if Teamcity stops complaining, Im happy as well so lets merge!

Where did you find this setting / the PROJECT_EXT_134 value?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] - Weekly user acceptance test broken because of some missing kotlin config

2 participants