Repository navigation
Issue #1931 fix stringdtype conversion - #1932
Merged
Merged
Conversation
JoerivanEngelen
added this pull request to stack #1933
October 12, 2026 13:25
JoerivanEngelen
force-pushed
the
issue_#1931_fix_stringdtype_conversion
branch
from
October 12, 2026 13:25
e5b8748 to
267ab2d
Compare
LuukBlom
approved these changes
Oct 12, 2026
LuukBlom
left a comment
LuukBlom
left a comment
Contributor
There was a problem hiding this comment.
LGTM,
I think the function could do with a slightly more descriptive name, but its also a bit nitpicky so up to you!
ClaireDons
approved these changes
Oct 12, 2026
ClaireDons
left a comment
ClaireDons
left a comment
Contributor
There was a problem hiding this comment.
Looks good, do you have a reminder somewhere to remove this when the numpy fix comes out?
Contributor
Author
Yes, I want to create a follow-up issue once this was merged. |
…eltares/imod-python into issue_#1931_fix_stringdtype_conversion
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1931
Description
Fixes breaking CI after lockfile update. An update in xarray triggers an error when reading string data from a zarr file. This introduces a temporary workaround which can be removed once numpy 2.6.0 is released (for which I didn't see any release date).
Checklist
Issue #nr, e.g.Issue #737pixi run generate-sbomand committed changes