Skip to content

refactor: remove TUI frontend and interactive approvals - #95

Merged
reiase merged 4 commits into
mainfrom
refactor/remove-tui
Nov 1, 2026
Merged

reiase merged 4 commits into
mainfrom
refactor/remove-tui

Conversation

@reiase

@reiase reiase commented Nov 1, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Remove the pvisor-tui binary, terminal UI implementation, companion dispatch, --tui / --ask, and TUI-specific runtime approval transport.
  • Keep ordinary interactive terminals, replay, --safe, and staged review/apply/drop. Reject unsupported ask policies without silently granting access; validate actual workspace policies and recorded/restored policies, and reject workspace forks before creating stages or checkpoint pins.
  • Remove TUI from builds, installation, wheels, releases, CI, examples, and bilingual documentation. Delete the D06 / S-DOC-023 and M02 / S-DOC-056 specifications and update conventional specification inventory tests. Leave real review ledgers and approval snapshots untouched.

Validation

Validated on macOS:

  • TMPDIR=/tmp mise run test -- pvisor-cli: 237 passed, 9 skipped.
  • mise run test -- pvisor-core: 77 passed.
  • mise run test-semspec: 50 Rust tests and 6 Python tests passed.
  • mise run test-py -- tests/test_application_boundary.py tests/test_release_packaging.py tests/test_vm_terminal.py benchmark/tests/test_startup_profile.py: 68 passed, 1 skipped (VM terminal hardware/environment unavailable).
  • mise run test-task-routing: passed.
  • cargo check --locked -p pvisor-cli --all-targets --features gateway: passed.
  • cargo check --locked -p pvisor-daemon -p pvisor-shim: passed.
  • mise run semspec -- lint docs/src/zh/cases docs/src/zh/reference: 88 cases, 4 preparation documents valid.
  • Documentation preflight, bilingual configuration reference check, targeted rustfmt checks, and git diff --check: passed.

Remaining validation failures and limits

  • TMPDIR=/tmp mise run test -- pvisor -- --no-fail-fast: 685 passed, 2 failed, 11 skipped. The failures are in unchanged snapshot-copy tests and reproduce when run individually:
    • environment_snapshot_store::layer_sharing_checks_reference_volume_and_private_copy_remains_available: filesystem inventory mismatch.
    • environment_snapshot_tree::owned_copies_isolate_source_and_sibling_writes: inode assertion mismatch.
  • Policies held only inside a selected private native VM checkpoint are checked after materialization into RestoredAttempt, before workload launch. Restore preparation may already have occurred; existing runtime failure/rollback semantics apply. No new runtime inspection API was added.
  • Linux platform validation, real release installation, and full bilingual site builds were not run.

@reiase

reiase commented Nov 1, 2026

Copy link
Copy Markdown
Collaborator Author

Rebased onto origin/main at a929abd. Resolved the CLI help-group conflict by retaining the new vm-run command and removing tui. Rebase validation: TMPDIR=/tmp mise run test -- pvisor-cli (238 passed, 9 skipped); mise run test-py -- tests/test_application_boundary.py tests/test_vm_cli_contract.py (13 passed); git diff --check passed. New head: 3771245.

@reiase
reiase force-pushed the refactor/remove-tui branch from 65776c6 to 3771245 Compare November 1, 2026 14:31
@reiase
reiase merged commit 94ff93a into main Nov 1, 2026
31 checks passed
@reiase
reiase deleted the refactor/remove-tui branch November 1, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant