Repository navigation
refactor: remove TUI frontend and interactive approvals - #95
Merged
Merged
Conversation
Collaborator
Author
|
Rebased onto origin/main at a929abd. Resolved the CLI help-group conflict by retaining the new vm-run command and removing tui. Rebase validation: TMPDIR=/tmp mise run test -- pvisor-cli (238 passed, 9 skipped); mise run test-py -- tests/test_application_boundary.py tests/test_vm_cli_contract.py (13 passed); git diff --check passed. New head: 3771245. |
reiase
force-pushed
the
refactor/remove-tui
branch
from
November 1, 2026 14:31
65776c6 to
3771245
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pvisor-tuibinary, terminal UI implementation, companion dispatch,--tui/--ask, and TUI-specific runtime approval transport.--safe, and staged review/apply/drop. Reject unsupported ask policies without silently granting access; validate actual workspace policies and recorded/restored policies, and reject workspace forks before creating stages or checkpoint pins.Validation
Validated on macOS:
TMPDIR=/tmp mise run test -- pvisor-cli: 237 passed, 9 skipped.mise run test -- pvisor-core: 77 passed.mise run test-semspec: 50 Rust tests and 6 Python tests passed.mise run test-py -- tests/test_application_boundary.py tests/test_release_packaging.py tests/test_vm_terminal.py benchmark/tests/test_startup_profile.py: 68 passed, 1 skipped (VM terminal hardware/environment unavailable).mise run test-task-routing: passed.cargo check --locked -p pvisor-cli --all-targets --features gateway: passed.cargo check --locked -p pvisor-daemon -p pvisor-shim: passed.mise run semspec -- lint docs/src/zh/cases docs/src/zh/reference: 88 cases, 4 preparation documents valid.git diff --check: passed.Remaining validation failures and limits
TMPDIR=/tmp mise run test -- pvisor -- --no-fail-fast: 685 passed, 2 failed, 11 skipped. The failures are in unchanged snapshot-copy tests and reproduce when run individually:environment_snapshot_store::layer_sharing_checks_reference_volume_and_private_copy_remains_available: filesystem inventory mismatch.environment_snapshot_tree::owned_copies_isolate_source_and_sibling_writes: inode assertion mismatch.RestoredAttempt, before workload launch. Restore preparation may already have occurred; existing runtime failure/rollback semantics apply. No new runtime inspection API was added.