fix: complete rclone OAuth configuration - #16
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8bdc8d4ffc
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| raise RcloneError(f"rclone config failed: {details}") | ||
|
|
||
| option = response.get("Option", response.get("option")) | ||
| if option: |
There was a problem hiding this comment.
Auto-answer Drive's shared-drive prompt
When configuring a normal My Drive remote with no team_drive, rclone's Drive post-config path asks the config_change_team_drive question after OAuth; its config protocol also requires any default config answers to be passed again on each --continue (see https://rclone.org/commands/rclone_config_create/#synopsis). Since this handler now rejects every returned Option, bbman auth-gdrive can complete the browser OAuth and then fail instead of accepting the default “no shared drive” answer. Add config_change_team_drive=false to the default parameters (and preserve it across continuations) before treating remaining options as unsupported.
Useful? React with 👍 / 👎.
Summary
auth-gdriveso ordinarybbmanstartup and dependency checks do not require the management package to import eagerly.ConfigOutRC response fields and reject actualOption/Errorresponses without leaking secrets.continue,state, andresult, bounded to 32 continuation calls.Verification
core/versionsmoke passed.This follows merged PR #15 and addresses its automated review findings.