Skip to content

fix: complete rclone OAuth configuration - #16

Merged
CruxExperts merged 1 commit into
mainfrom
fix/gdrive-oauth-review
Aug 4, 2026
Merged

CruxExperts merged 1 commit into
mainfrom
fix/gdrive-oauth-review

Conversation

@CruxExperts

Copy link
Copy Markdown
Owner

Summary

  • Lazily load Google Drive management support inside auth-gdrive so ordinary bbman startup and dependency checks do not require the management package to import eagerly.
  • Handle rclone's capitalized ConfigOut RC response fields and reject actual Option/Error responses without leaking secrets.
  • Continue state-only rclone config transitions using continue, state, and result, bounded to 32 continuation calls.
  • Add regression coverage for lazy imports, redaction, pending questions, and the exact continuation boundary.

Verification

  • Full suite: 620 passed.
  • Ruff, py_compile, generated CLI metadata, version sync, publishing readiness, and diff checks passed.
  • Real local rclone RC core/version smoke passed.
  • Independent follow-up review: no material findings.
  • No credentials or tokens committed.

This follows merged PR #15 and addresses its automated review findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8bdc8d4ffc

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

raise RcloneError(f"rclone config failed: {details}")

option = response.get("Option", response.get("option"))
if option:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Auto-answer Drive's shared-drive prompt

When configuring a normal My Drive remote with no team_drive, rclone's Drive post-config path asks the config_change_team_drive question after OAuth; its config protocol also requires any default config answers to be passed again on each --continue (see https://rclone.org/commands/rclone_config_create/#synopsis). Since this handler now rejects every returned Option, bbman auth-gdrive can complete the browser OAuth and then fail instead of accepting the default “no shared drive” answer. Add config_change_team_drive=false to the default parameters (and preserve it across continuations) before treating remaining options as unsupported.

Useful? React with 👍 / 👎.

@CruxExperts
CruxExperts merged commit 0ce7573 into main Aug 4, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant