Repository navigation
fix(desktop): read app.asar entries by native path in the bundle audit - #120
Merged
Merged
Conversation
The v0.0.69 Windows release failed in the new import check: @electron/asar looks entries up by native path, so "desktop/main/index.mjs" was not found on Windows. Convert to path.sep before extracting. Gate: G0 green; mac bundle audit passes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.0.69 Windows release failed in the new app.asar import check:
@electron/asarlooks entries up by native path, sodesktop/main/index.mjswasn't found on Windows. Mac and Linux passed.Test plan
🤖 Generated with Claude Code