Skip to content

Build composed Storybook once and share it with the story test shards - #567

Closed
woksin wants to merge 1 commit into
mainfrom
l163/453-storybook-share
Closed

woksin wants to merge 1 commit into
mainfrom
l163/453-storybook-share

Conversation

@woksin

@woksin woksin commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

Changed

@woksin woksin added the no-release Merging publishes no package, image, release, or deployment label Nov 21, 2026
@woksin woksin self-assigned this Nov 21, 2026
@woksin

woksin commented Nov 21, 2026

Copy link
Copy Markdown
Contributor Author

Reviewer notes

  • Adds one producer job that runs the unchanged package builds and the composed Storybook build once, then uploads a same-run artifact (static Storybook plus Source, Conformance and adapter dist output). The three Storybook shards download it instead of rebuilding; preflight specs, index verification, the three story partitions and all check names are kept. Missing upload or download fails the job.
  • The Build aggregator and the gate script's job list include the new job; gate tests cover it.
  • Local: root yarn ci passed on this head; gate tests pass (87); actionlint passes.
  • This is a measured experiment. Baseline (run 44935521153): each shard spent 75–96 s on package and Storybook builds, Storybook shard jobs 252–305 s. It merges only if this PR's run shows runner time saved after artifact upload/download and setup, without a material wall-clock regression.

@woksin

woksin commented Nov 21, 2026

Copy link
Copy Markdown
Contributor Author

Closing after measurement: about 114 runner-seconds are saved per run, but each run takes about 60–70 s longer from start to finish, and hosted runners are free for this public repository. The numbers are on #453.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-release Merging publishes no package, image, release, or deployment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant