Skip to content

Restore dependency updates through reviewed pull requests #215

Open

Description

@woksin

Problem

Components 4 intentionally replaced direct scheduled package mutation with a permissions-empty failing workflow while the dependency graph and publication boundary were being secured. The committed lockfile and immutable CI now make updates reproducible, but there is no automated PR-producing replacement.

Direction

Restore automation only as reviewed pull requests:

  • update manifests and the single root lockfile together;
  • never push directly to main;
  • never publish, dispatch release workflows, or receive publication credentials;
  • group low-risk patches conservatively and isolate renderer-major/package-manager changes;
  • run compatibility generation, public types, package graph, adapter boundaries, Storybook, production audit, and release-evidence self-tests before merge;
  • expose lockfile, checksum, peer-warning, and exception-metadata changes in the PR.

Acceptance criteria

  • Scheduled/manual automation opens a branch and PR with least-privilege permissions.
  • Main and publication paths remain unreachable.
  • Lockfile installs immutably and checksum changes are reviewable.
  • PrimeReact 10/11 remain isolated and bounded.
  • Upstream type exceptions fail stale when a dependency update fixes them.
  • Failure leaves no direct repository or registry mutation.

Activity

  1. woksin commented on Sep 26, 2026

    @woksin
    ContributorAuthor

    Containment merged in #341: the scheduled run of the dependency updater is paused, because the shared workflow's default publication mode pushes directly to main and this caller did not select pull-request mode. It can still be run manually. Remaining for this issue: an explicit publication-mode: pull-request caller configuration that the bootstrap bot keeps, and a PR-scoped credential (a GitHub App is recommended) instead of PAT_WORKFLOWS.

  2. self-assigned this
    on Sep 26, 2026
  3. woksin commented on Sep 28, 2026

    @woksin
    ContributorAuthor

    Decision: restore scheduled updates only as reviewed pull requests. This needs a repository-scoped GitHub App with only Contents and Pull requests write access, used by a caller that sets publication-mode: pull-request explicitly. The shared Cratis/Workflows updater and its bootstrap template must mint that App token and keep PR mode. The App has no publish credential and no permission to bypass main's protection. The workflow stays manual-only until then. Blocked on an organization admin creating and installing the App.

  4. reopened this on Oct 22, 2026
  5. woksin commented on Oct 29, 2026

    @woksin
    ContributorAuthor

    Analysis and proposed solution

    Current behaviour — Components' dependency-update caller is manual-only and passes PAT_WORKFLOWS without selecting PR mode. The shared workflow defaults to direct publication. However, repository-scoped App-token minting is already implemented. The bootstrap template still emits a scheduled PAT-based caller without explicit PR mode.

    Root cause / gap — Pausing the schedule contained automatic direct pushes but did not make manual invocation PR-only. The remaining work is caller configuration, bootstrap preservation, repository-specific validation and credential provisioning—not implementing App-token support from scratch.

    Proposed change — Set publication-mode: pull-request explicitly, replace the PAT mapping with AUTOMATION_APP_PRIVATE_KEY, and use CRATIS_AUTOMATION_APP_ID. Fail closed when App configuration is absent rather than falling back to another credential. Update the bootstrap template and its specifications so synchronization preserves PR-only mode, App authentication and the paused schedule. Configure validation of manifests plus the root lockfile, compatibility generation, public types, package/adapter boundaries, Storybook, production audit and release-evidence self-tests. Keep renderer-major/package-manager updates separate and expose checksum, peer-warning and exception changes in the PR. Extend workflow specifications for missing credentials, failed validation, no-change runs, and prohibitions on main pushes, release dispatch and publication credentials. Restore scheduling only after provisioning and a reviewed manual PR demonstrate the complete path.

    Size, risk, release intent — M; high workflow-permission risk; no-release.

    Dependencies — Organization-admin App creation/installation and protected-main configuration remain prerequisites; recorded containment: #341.

  6. removed their assignment
    on Nov 4, 2026
  7. self-assigned this
    on Nov 21, 2026
  8. woksin commented on Nov 21, 2026

    @woksin
    ContributorAuthor

    The pull-request-only caller is merged in #572: the dependency-update workflow selects pull-request publication explicitly, uses only the Cratis automation App key (no personal access token), and fails in a preflight job before any change when CRATIS_AUTOMATION_APP_ID or AUTOMATION_APP_PRIVATE_KEY is not configured. It remains manual-only. Remaining for this issue: an organization admin provisions the App with Contents and Pull requests write access, a manual run is verified to produce a reviewed pull request, and the schedule is restored after that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions