Skip to content

KeyboardTextReader.Read waits for a key event. - #3293

Draft
Guillermo-Santos wants to merge 1 commit into
CosmosOS:gen3from
Guillermo-Santos:gen3
Draft

KeyboardTextReader.Read waits for a key event.#3293
Guillermo-Santos wants to merge 1 commit into
CosmosOS:gen3from
Guillermo-Santos:gen3

Conversation

@Guillermo-Santos

@Guillermo-Santos Guillermo-Santos commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator

This makes sure that Console.Read waits for a key input or de session to be terminated to return.

Closes #3276

@Guillermo-Santos
🐛 Use ConsoleSession.WaitForKey for input retrieval in KeyboardTextRe…
dff1532 
…ader.Read

This makes sure that Console.Read waits for a key input or de session to be terminated to return.
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown

🧪 Fat Tests

Cell x64 arm64
all ✅ 42/42 ✅ 42/42

📎 Artifacts

Architecture Test Results UART Log Kernel ISO
x64 XML Log ISO
arm64 XML Log ISO

📋 View full test summary | 📄 Kernel.cs

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown

🧪 File Tests

Cell x64 arm64
all ✅ 37/37 ✅ 37/37

📎 Artifacts

Architecture Test Results UART Log Kernel ISO
x64 XML Log ISO
arm64 XML Log ISO

📋 View full test summary | 📄 Kernel.cs

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown

🧪 GarbageCollector Tests

Cell x64 arm64
all ✅ 50/50 ✅ 50/50

📎 Artifacts

Architecture Test Results UART Log Kernel ISO
x64 XML Log ISO
arm64 XML Log ISO

📋 View full test summary | 📄 Kernel.cs

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown

🧪 HelloWorld Tests

Cell x64 arm64
all ✅ 3/3 ✅ 3/3

📎 Artifacts

Architecture Test Results UART Log Kernel ISO
x64 XML Log ISO
arm64 XML Log ISO

📋 View full test summary | 📄 Kernel.cs

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown

🧪 Memory Tests

Cell x64 arm64
all ✅ 71/71 ✅ 71/71

📎 Artifacts

Architecture Test Results UART Log Kernel ISO
x64 XML Log ISO
arm64 XML Log ISO

📋 View full test summary | 📄 Kernel.cs

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown

🧪 Network Tests

Cell x64 arm64
all ✅ 48/48 ✅ 48/48
e1000e ✅ 24/24 n/a
virtio-net-mmio n/a ✅ 24/24
virtio-net-pci ✅ 24/24 ✅ 24/24

📎 Artifacts

Architecture Test Results UART Log Kernel ISO
x64 XML Log ISO
arm64 XML Log ISO

📋 View full test summary | 📄 Kernel.cs

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown

🧪 Pci Tests

Cell x64 arm64
all ✅ 8/8 ✅ 8/8

📎 Artifacts

Architecture Test Results UART Log Kernel ISO
x64 XML Log ISO
arm64 XML Log ISO

📋 View full test summary | 📄 Kernel.cs

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown

🧪 Power Tests

Cell x64 arm64
all ✅ 4/4 ✅ 4/4

📎 Artifacts

Architecture Test Results UART Log Kernel ISO
x64 XML Log ISO
arm64 XML Log ISO

📋 View full test summary | 📄 Kernel.cs

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown

🧪 Runtime Tests

Cell x64 arm64
all ✅ 103/103 ✅ 103/103

📎 Artifacts

Architecture Test Results UART Log Kernel ISO
x64 XML Log ISO
arm64 XML Log ISO

📋 View full test summary | 📄 Kernel.cs

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown

🧪 Storage Tests

Cell x64 arm64
all ✅ 586/664, 78 skip ✅ 2165/2490, 325 skip
ahci ✅ 70/83, 13 skip ✅ 70/83, 13 skip
ahci+acpi-off ✅ 70/83, 13 skip ✅ 70/83, 13 skip
ahci+gicv2 n/a ✅ 70/83, 13 skip
ahci+gicv2+acpi-off n/a ✅ 70/83, 13 skip
ahci+gicv3 n/a ✅ 70/83, 13 skip
ahci+gicv3+acpi-off n/a ✅ 70/83, 13 skip
nvme ✅ 73/83, 10 skip ✅ 70/83, 13 skip
nvme+acpi-off ✅ 73/83, 10 skip ✅ 71/83, 12 skip
nvme+gicv2 n/a ✅ 71/83, 12 skip
nvme+gicv2+acpi-off n/a ✅ 71/83, 12 skip
nvme+gicv3 n/a ✅ 71/83, 12 skip
nvme+gicv3+acpi-off n/a ✅ 71/83, 12 skip
usb ✅ 75/83, 8 skip ✅ 75/83, 8 skip
usb+acpi-off ✅ 75/83, 8 skip ✅ 75/83, 8 skip
usb+gicv2 n/a ✅ 75/83, 8 skip
usb+gicv2+acpi-off n/a ✅ 75/83, 8 skip
usb+gicv3 n/a ✅ 75/83, 8 skip
usb+gicv3+acpi-off n/a ✅ 75/83, 8 skip
virtio-blk-mmio n/a ✅ 70/83, 13 skip
virtio-blk-mmio+acpi-off n/a ✅ 70/83, 13 skip
virtio-blk-mmio+gicv2 n/a ✅ 70/83, 13 skip
virtio-blk-mmio+gicv2+acpi-off n/a ✅ 70/83, 13 skip
virtio-blk-mmio+gicv3 n/a ✅ 70/83, 13 skip
virtio-blk-mmio+gicv3+acpi-off n/a ✅ 70/83, 13 skip
virtio-blk-pci ✅ 75/83, 8 skip ✅ 75/83, 8 skip
virtio-blk-pci+acpi-off ✅ 75/83, 8 skip ✅ 75/83, 8 skip
virtio-blk-pci+gicv2 n/a ✅ 75/83, 8 skip
virtio-blk-pci+gicv2+acpi-off n/a ✅ 75/83, 8 skip
virtio-blk-pci+gicv3 n/a ✅ 75/83, 8 skip
virtio-blk-pci+gicv3+acpi-off n/a ✅ 75/83, 8 skip

Skipped

  • x64: 78 skipped: not a USB profile (30), no hot-pluggable PCI disk on this cell (30), 64-bit BAR relocation probe is nvme-profile only (12), not an NVMe profile (6)
  • arm64: 325 skipped: not a USB profile (120), no hot-pluggable PCI disk on this cell (120), x64 mapper cell; arm64 installs Device mappings via DeviceMapper (30), BAR relocation probe is x64-only (same harness as the mapper cell) (30), not an NVMe profile (24), interrupt mode not pinned by this cell (1)

📎 Artifacts

Architecture Test Results UART Log Kernel ISO
x64 XML Log ISO
arm64 XML Log ISO

📋 View full test summary | 📄 Kernel.cs

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown

🧪 Threading Tests

Cell x64 arm64
all ✅ 78/78 ✅ 78/78

📎 Artifacts

Architecture Test Results UART Log Kernel ISO
x64 XML Log ISO
arm64 XML Log ISO

📋 View full test summary | 📄 Kernel.cs

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown

🧪 Virtio Tests

Cell x64 arm64
all ✅ 24/28, 4 skip ✅ 48/56, 8 skip
virtio-mmio n/a ✅ 12/14, 2 skip
virtio-mmio+acpi-off n/a ✅ 12/14, 2 skip
virtio-pci ✅ 12/14, 2 skip ✅ 12/14, 2 skip
virtio-pci+acpi-off ✅ 12/14, 2 skip ✅ 12/14, 2 skip

Skipped

  • x64: 4 skipped: this cell presents virtio over PCI (4)
  • arm64: 8 skipped: this cell presents virtio over PCI (4), this cell presents virtio over MMIO (4)

📎 Artifacts

Architecture Test Results UART Log Kernel ISO
x64 XML Log ISO
arm64 XML Log ISO

📋 View full test summary | 📄 Kernel.cs

@Guillermo-Santos
Guillermo-Santos marked this pull request as draft October 8, 2026 03:36
@Guillermo-Santos

Guillermo-Santos commented Oct 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

@zarlo seeing your PR for #3274, what do you think if i make ConsoleSession transfer the KeyEvents from the RingBuffer to an internal Queue inside the ConsoleSession? that would make this PR easier to do (To make Console.Read behave as the dotnet implementation we need to make it read a line without consuming the KeyEvents and only return the first key of that line and the other keys should be available for the next calls, but doing so right now requires some other changes).

@zarlo

zarlo commented Oct 8, 2026

Copy link
Copy Markdown
Member

@zarlo seeing your PR for #3274, what do you think if i make ConsoleSession transfer the KeyEvents from the RingBuffer to an internal Queue inside the ConsoleSession? that would make this PR easier to do (To make Console.Read behave as the dotnet implementation we need to make it read a line without consuming the KeyEvents and only return the first key of that line and the other keys should be available for the next calls, but doing so right now requires some other changes).

If it's using the peak method, it won't consume.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Console.Read() returns -1 when no key is waiting

2 participants

@Guillermo-Santos @zarlo