Skip to content

Fix the three red CI checks: Anthropic 2.x in the agent tests, the Chromium enter-text launches, and a React teardown - #863

Open
davidmckayv wants to merge 4 commits into
mainfrom
david/ci-anthropic2-chromium
Open

davidmckayv wants to merge 4 commits into
mainfrom
david/ci-anthropic2-chromium

Conversation

@davidmckayv

@davidmckayv davidmckayv commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

What this changes

Three CI checks are red on main and on every open PR. None of them is caused by product code.

  • python harness regressions: the agents' requirements are unpinned, and they now resolve anthropic 2.x. That SDK sends the key as Authorization: Bearer instead of x-api-key, and dates its Messages API version later than 2023-06-01. agent-langgraph-agui/tests/test_provider_boundaries.py asserted both by their 1.x values. It now reads the key from either header and checks that the version is a date. The endpoint, key, model and body it asserts are unchanged. This PR also carries Read the Anthropic key from either header in the AG2 test #859's identical AG2 commit, so it is green on its own and merges cleanly whichever lands first. main's run stops at AG2, which is why the LangGraph failure hadn't shown there yet.

  • computer (real browser): since fix(computer): install only the Chromium build the computer launches #829, CI installs Chromium with --no-shell. agent-computer/tests/enter-text.test.ts launched Playwright's default build, the separate headless shell, which is no longer on the runner, so it never started. It now launches channel: "chromium", the build the computer itself launches.

  • tests (unhandled error between tests): app/tests/self-host-banner.test.tsx unregistered happy-dom while the Dismiss save still had a render posted. That render fired against a missing document, so bun reported zero failures and a red job. afterAll now awaits settleReactWork() first, as the other React tests do (see app/tests/settle-react-work.ts).

Local results: the LangGraph AG-UI suite passes (90, on anthropic 2.3.0), enter-text passes (5), and the banner tests pass three runs out of three. The flake itself only reproduced on CI.

Where it runs

  • New state that outlives a request? None; only tests change.
  • What happens on the second replica? Nothing; only tests change.
  • Anything serialised? No.
  • Anything fanned out to a browser? No.
  • New listener, port, or schedule? No.

Boundary and audit

  • Every acting call still goes through the gateway. No product code changes.
  • New refusals and new failures each write a row. None are new.
  • Nothing new is trusted from the client.

Changelog

  • No line: only tests change, so a deployment behaves no differently afterwards.

…raph AG-UI test

anthropic 2.x sends the key as Authorization: Bearer instead of x-api-key and
dates its Messages API version later than 2023-06-01. The provider-boundary
test asserted both by their 1.x values, so it failed once the unpinned
requirements resolved 2.x. It now reads the key from either header and checks
the version is a date; the endpoint, key, model and body it asserts are
unchanged.
CI installs Chromium with --no-shell since #829, and enter-text launched
Playwright's default, the separate headless shell, so it failed to start.
It now launches channel "chromium", the build the computer itself launches.
Anthropic's SDK 2.3.0, which CI now installs for the AG2 harness, sends the
key as Authorization: Bearer instead of x-api-key. The agent's key still
reaches Anthropic; the test only looked for the old header, so it failed on
every pull request. It now accepts either, and passes with Anthropic's SDK
1.17.0 and 2.3.0 alike.

(cherry picked from commit a1391e7)
The Dismiss save settles a render after the last test returns, and afterAll
unregistered happy-dom first, so the render fired against a missing document
and bun reported an unhandled error between tests: zero failures, a red job.
afterAll now awaits settleReactWork first, as the other React tests do.
@davidmckayv davidmckayv changed the title Fix the two red CI checks: Anthropic 2.x in the LangGraph AG-UI test, and the Chromium enter-text launches Fix the three red CI checks: Anthropic 2.x in the agent tests, the Chromium enter-text launches, and a React teardown Oct 28, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant