Repository navigation
feat(example-sets): a data-subject request in the Zuiddrecht set - #4795
Merged
Merged
Conversation
LqCfPrivacyverzoek opens a data-subject request from OpenRegister's shared data-subject-requests register, which learniq reads through the objects API, and the demo instance holds none. The Zuiddrecht cast file now writes one: a parent's erasure request for a former pupil, in progress, handled by Pieter, with its statutory term still running. Assisted-by: ClaudeCode:claude-opus-5-5
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ✅ | ||||
| test-l10n-parity | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 173/173 | |||
| npm | ❌ | ✅ 648/648 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ | ||||
| Newman | ❌ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-10-23 03:08 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Zuiddrecht cast file now writes one data-subject request in the shared
data-subject-requestsregister: a parent's erasure request for a former pupil. It is in progress, Pieter handles it, it was received 35 days before the install, and 11 days of its statutory term remain, as the board draws it.Why
LqCfPrivacyverzoek opens a data-subject request, which learniq reads from this register through the objects API. The demo instance holds none. A learniq example set may only write learniq's own register, so the record belongs in OpenRegister's own fragment.
Verified
ZuiddrechtDataSubjectRequestTest(new) fails on development and passes here.ExampleSetCatalogueTestpasses.validate_example_set.pyagainstdata_subject_request_register.jsonraises no refusal for the new object.COMPOSER_PROCESS_TIMEOUT=0 composer check:strict: exit 1, every finding inherited.tests/Unit/Db: AuditTrailActionPrefix 4, AuditTrailMapperReadHistory 4, AuditTrailMapperRevertQuery 4, AuditTrailToolInvocationInsert 1 and DraftRemovalAuditRow 2. They fail becauseOC\DB\QueryBuilder\CompositeExpressioncannot be found outside a server tree.AI-assisted: written with Claude Code (claude-opus-5-5) and reviewed before submission.