Repository navigation
fix(screens): DqNieuweZaak's dialog subtitle at line height 1.5, with its asterisk - #375
Merged
Merged
Conversation
… its asterisk The New case dialog drew its subtitle at the normal line height, where DqBerichtVersturen and DqOverdragen draw the same dialog subtitle at 1.5; two boards of three set the canon (coordinator, 23 Oct). The asterisk in "Velden met * zijn verplicht" had dropped out of the source, so the sentence read "Velden met zijn verplicht"; the English catalogue key follows. screens.json is left as it was. Assisted-by: ClaudeCode:claude-opus-5-5
Contributor
Quality Report — ConductionNL/design-system @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ⏭️ | ||||
| phpcs | ⏭️ | ||||
| phpmd | ⏭️ | ||||
| psalm | ⏭️ | ||||
| phpstan | ⏭️ | ||||
| phpmetrics | ⏭️ | ||||
| eslint | ⏭️ | ||||
| stylelint | ⏭️ | ||||
| build | ⏭️ | ||||
| composer | ✅ | ✅ | |||
| npm | ✅ | ✅ | |||
| app:check-code | ⏭️ | ||||
| info.xml | ⏭️ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ⏭️ | ||||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ | ||||
| Hydra gates | ⏭️ |
Quality workflow — 2026-10-23 08:49 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DqNieuweZaak drew the dialog subtitle at the normal line height. DqBerichtVersturen and DqOverdragen draw the same subtitle at 1.5, and the majority sets the canon, as the coordinator ruled on 23 Oct. The "*" in "Velden met * zijn verplicht" had dropped out of the source; it is back, and the English catalogue key follows.
Rebuilt with
build.py --only DqNieuweZaak(board, thumb, heights 2064 to 2072). screens.json is untouched.i18n.py checkgoes from 16 errors on main to 15: this board's key mismatch is fixed, and the rest are inherited.🤖 Generated with Claude Code