Remove basePath so assets resolve at custom domain root - #26
Merged
Merged
Conversation
The site now serves from python.org.co at the domain root instead of colombiapython.github.io/web/, so the /web basePath prefix caused all CSS/JS assets to 404. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
rmunate
approved these changes
Sep 11, 2026
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Update the metadata base so generated image URLs use the custom domain.
Pull request overview
Removes the hardcoded /web path so the site serves assets correctly from the custom domain root.
Changes:
- Removes the repository-derived
basePath/assetPrefix. - Preserves static export configuration for root hosting.
File summaries
| File | Summary |
|---|---|
next.config.ts |
Removes the /web deployment prefix; SEO metadata still references the old GitHub Pages host. |
Review details
Suppressed comments (1)
next.config.ts:3
- This switches the build to the custom-domain root, but CI still sets
GITHUB_ACTIONS, soresolveMetadataBase()inlib/seo.tscontinues to usehttps://ColombiaPython.github.io. As a result, the relative Open Graph/Twitter image URLs generated during this same build still point at the old host; update that metadata-base logic along with the deployment-host change.
const basePath = "";
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
python.org.coat the domain root instead ofcolombiapython.github.io/web/.next.config.tswas hardcodingbasePath/assetPrefixto/web(derived from the GitHub repo name), which made all CSS/JS assets 404 once served from the custom domain root, breaking the site's styling./webbasePath so assets resolve correctly at/.Test plan
npm run buildsucceedsdist/index.htmlhas zero/web/references and assets point to/_next/...at root🤖 Generated with Claude Code