Skip to content

Remove basePath so assets resolve at custom domain root - #26

Merged
karobotco merged 1 commit into
mainfrom
fix/remove-base-path
Sep 11, 2026
Merged

karobotco merged 1 commit into
mainfrom
fix/remove-base-path

Conversation

@karobotco

Copy link
Copy Markdown
Member

Summary

  • The site now serves from python.org.co at the domain root instead of colombiapython.github.io/web/.
  • next.config.ts was hardcoding basePath/assetPrefix to /web (derived from the GitHub repo name), which made all CSS/JS assets 404 once served from the custom domain root, breaking the site's styling.
  • Removed the /web basePath so assets resolve correctly at /.

Test plan

  • npm run build succeeds
  • Verified generated dist/index.html has zero /web/ references and assets point to /_next/... at root
  • After merge + deploy, confirm https://python.org.co loads styled correctly

🤖 Generated with Claude Code

The site now serves from python.org.co at the domain root instead of
colombiapython.github.io/web/, so the /web basePath prefix caused all
CSS/JS assets to 404.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@rmunate
rmunate requested a lite review from Copilot September 11, 2026 20:56
@karobotco
karobotco merged commit 63bb8da into main Sep 11, 2026
1 check passed
@karobotco
karobotco deleted the fix/remove-base-path branch September 11, 2026 20:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Update the metadata base so generated image URLs use the custom domain.

Pull request overview

Removes the hardcoded /web path so the site serves assets correctly from the custom domain root.

Changes:

  • Removes the repository-derived basePath/assetPrefix.
  • Preserves static export configuration for root hosting.
File summaries
File Summary
next.config.ts Removes the /web deployment prefix; SEO metadata still references the old GitHub Pages host.
Review details

Suppressed comments (1)

next.config.ts:3

  • This switches the build to the custom-domain root, but CI still sets GITHUB_ACTIONS, so resolveMetadataBase() in lib/seo.ts continues to use https://ColombiaPython.github.io. As a result, the relative Open Graph/Twitter image URLs generated during this same build still point at the old host; update that metadata-base logic along with the deployment-host change.
const basePath = "";
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants