Repository navigation
fix(alphatex): accept fractional harmonic values - #2941
Merged
Merged
Conversation
The value of ah/th/ph/sh/fh was declared as an integer parameter, so a
fractional value like {ah 2.4} written by the exporter failed to parse
on re-import (AT206/AT202). Declare it as an optional float.
Fixes #2896
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
AI-authored disclosure (
alphatab-ai-authored-v1)Portions of this content were authored by an AI agent. The agent has read
AGENTS.md and the human submitter accepts responsibility for
compliance with the rules in that document.
Issues
Fixes #2896
Proposed changes
#2896: the alphaTex exporter writes fractional harmonic values as they are, e.g.
{ah 2.4}, but the importer rejects that output with AT206/AT202. Guitar Pro uses such values (2.4,2.7,3.5,8.5, …), so these scores cannot be loaded again after an export.The alphaTex lexer reads
2.4as2,.,4, because<fret>.<string>depends on that. An argument is only read as a float where its parameter is declared as one (RequiredAsFloat/OptionalAsFloat). The value parameter ofah,th,ph,shandfhwas declared as a plainOptional(integer). The importer therefore read2, and the.that followed broke the property group.The fix declares that parameter as
OptionalAsFloat, as fermata length already does, and regeneratesAlphaTex1LanguageDefinitions.ts. The lexer, parser, importer and exporter are unchanged.3.3{ah 2.4}(same forth,ph,sh,fh)harmonicValue = 2.43.3{ah 7}3.3{ah}harmonicValue = 2.4Tests
AlphaTexImporter.test.ts: newharmonic-values-fractionaltest. It imports one fractional value for each of the five harmonic types and checks type and value, then exports and re-imports. It fails before the fix with the errors from the issue.The TypeScript, C# and Kotlin builds and test suites pass.
Checklist
AI authorship disclosure
(
alphatab-ai-authored-v1) is present at the top of this body, and I havepersonally reviewed every change and can explain each one
Further details