Repository navigation
fix(importer): read MusicXML fingering digits by instrument convention - #2927
Merged
Merged
Conversation
On non-piano parts <fingering> digits now follow the fretting hand numbering (0 = open, 1 = index ... 4 = little, 5 = thumb) instead of the keyboard numbering, matching how the renderer displays fingers. Adds the remaining SMuFL fingering letters (T, e, o, q, s, x) and case-insensitive matching. Fixes #2826
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
AI-authored disclosure (
alphatab-ai-authored-v1)Portions of this content were authored by an AI agent. The agent has read
AGENTS.md and the human submitter accepts responsibility for
compliance with the rules in that document.
Issues
Fixes #2826
Proposed changes
The MusicXML importer read
<fingering>digits with keyboard numbering (1 = thumb) on every instrument. On guitar and other non-piano parts a written1(index) therefore became the thumb and was shown ast, and every other finger was off by one.Why the numbering depends on the instrument:
<fingering>is free text, "typically indicated 1,2,3,4,5" (w3c-cg/musicxml#438: "any string value is valid").FingeringGroupGlyph.fingerToMusicFontSymbol), switching onGeneralMidi.isPiano(program). Only the importer ignored the instrument.What changes (in
_parseFingering, still a single switch):<fingering><fingering>and<pluck>01/2/3/45p,t,Ti/m/ac,e,o,q,s,x<fingering>on tracks whereGeneralMidi.isPiano(program)is false. That is the same check the renderer uses, so fingerings display as written.Tand the SMuFL little-finger letterse o q s xare new. Letters now match case-insensitively._parseFingeringrecords this reasoning.<midi-program>, so they count as piano and are unaffected.Checklist
New test:
MusicXmlImporterTests > fingering, usingtest-data/musicxml4/fingering.xml. It has a guitar part and a piano part, each with every input value as<fingering>and as<pluck>, and it checks every column of the table above. The TypeScript, C# and Kotlin test suites pass.AI authorship disclosure
(
alphatab-ai-authored-v1) is present at the top of this body, and I havepersonally reviewed every change and can explain each one
Further details