Skip to content

Binder cleanup - #287

Merged
BBooijLiewes merged 2 commits into
masterfrom
binder_cleanup
Oct 22, 2026
Merged

BBooijLiewes merged 2 commits into
masterfrom
binder_cleanup

Conversation

@BBooijLiewes

Copy link
Copy Markdown
Contributor
  • Fix that CI runs on both forks and CY PR's
  • CI runs on master/PR's only to help Github :)
  • Fix failing test

@BBooijLiewes BBooijLiewes self-assigned this Oct 22, 2026
@BBooijLiewes
BBooijLiewes requested a review from BlayeeR October 22, 2026 10:09

@BlayeeR BlayeeR left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three remarks:

  1. Don't we want CI also in branches, before you create a PR? May be nice to run tests when you are developing new changes, but it's up to a discussion what workflow do we prefer for working on new stuff.
  2. Maybe would be nice to include tags to also have CI?
  3. I would bump codecov(can be in separate PR) since it seems to be depreciated for a few years already

@BBooijLiewes

Copy link
Copy Markdown
Contributor Author
  • Don't we want CI also in branches, before you create a PR? May be nice to run tests when you are developing new changes, but it's up to a discussion what workflow do we prefer for working on new stuff.
  1. Reasoning was with AI dev and not overwelming/hitting github limits but may be pre-optimization. However I myself just run tests locally and only check CI once I have a pr. do you have a hard preference @BlayeeR ?
  2. agree
  3. agree, lets do in this Pr

@BlayeeR

BlayeeR commented Oct 22, 2026

Copy link
Copy Markdown
Collaborator
  • Don't we want CI also in branches, before you create a PR? May be nice to run tests when you are developing new changes, but it's up to a discussion what workflow do we prefer for working on new stuff.
  1. Reasoning was with AI dev and not overwelming/hitting github limits but may be pre-optimization. However I myself just run tests locally and only check CI once I have a pr. do you have a hard preference @BlayeeR ?
  2. agree
  3. agree, lets do in this Pr

Agree with 1.. django-binder is not that big repository, so running all the tests locally is the matter of seconds. We can exclude CI from non PR/tags/master branches for now and bring it back later if needed.
3. Lets do separate as it requires additional steps(acquiring a token) at codecov side

@BlayeeR
BlayeeR self-requested a review October 22, 2026 11:49

@BlayeeR BlayeeR left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BBooijLiewes
BBooijLiewes merged commit 45a64c6 into master Oct 22, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants