Repository navigation
Binder cleanup - #287
Merged
Merged
Binder cleanup#287
Conversation
BBooijLiewes
commented
Oct 22, 2026
Contributor
- Fix that CI runs on both forks and CY PR's
- CI runs on master/PR's only to help Github :)
- Fix failing test
BlayeeR
reviewed
Oct 22, 2026
BlayeeR
left a comment
Collaborator
There was a problem hiding this comment.
Three remarks:
- Don't we want CI also in branches, before you create a PR? May be nice to run tests when you are developing new changes, but it's up to a discussion what workflow do we prefer for working on new stuff.
- Maybe would be nice to include tags to also have CI?
- I would bump codecov(can be in separate PR) since it seems to be depreciated for a few years already
Contributor
Author
|
Collaborator
Agree with 1.. django-binder is not that big repository, so running all the tests locally is the matter of seconds. We can exclude CI from non PR/tags/master branches for now and bring it back later if needed. |
BlayeeR
force-pushed
the
binder_cleanup
branch
from
October 22, 2026 11:48
f4899b7 to
191e560
Compare
BlayeeR
self-requested a review
October 22, 2026 11:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.