Repository navigation
Fix token authentication for deleted users - #286
Merged
BBooijLiewes merged 2 commits intoOct 22, 2026
Merged
BBooijLiewes merged 2 commits into
BBooijLiewes merged 2 commits into
Conversation
…but a 200 error instead
stefanmajoor
force-pushed
the
crtx-969-fix-token-authentication-for-deleted-users
branch
from
October 22, 2026 09:02
a8f925a to
0258654
Compare
stefanmajoor
force-pushed
the
crtx-969-fix-token-authentication-for-deleted-users
branch
from
October 22, 2026 09:07
0258654 to
d83c52a
Compare
BBooijLiewes
self-requested a review
October 22, 2026 09:16
BBooijLiewes
approved these changes
Oct 22, 2026
BBooijLiewes
left a comment
BBooijLiewes
left a comment
Contributor
There was a problem hiding this comment.
Good find, thanks @stefanmajoor!
Contributor
|
ah lets check that pipelines run first, will trigger that one as double check |
Contributor
|
Ran locally one non related failure, merging this and then fixing pipelines and failure in seperate PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a security issue where tokens belonging to deleted users are still valid.
Currently when you have a token generated for the user, and you delete that user, the token is still valid. It can still be used to access the system. This PR only allows tokens to be used for users that are active.