MSPCA-2: get volunteer by id and update volunteer by id - #2
Open
shreeyaadhikari wants to merge 23 commits into
Open
shreeyaadhikari wants to merge 23 commits into
shreeyaadhikari wants to merge 23 commits into
Conversation
… sa/mspca-2-get-volunteer-by-id-and-update-volunteer-by-id
shreeyaadhikari
marked this pull request as ready for review
September 27, 2026 21:14
dburkhart07
requested changes
Sep 28, 2026
dburkhart07
left a comment
dburkhart07
left a comment
Collaborator
There was a problem hiding this comment.
A lot of just small nits and general style guidelines that we will follow throughout development. Logic looks really great so far. Ty Shreeya!!!! 🐼
| @@ -0,0 +1,6 @@ | |||
| approvedGitRepositories: | |||
Collaborator
There was a problem hiding this comment.
I don't think we need this file or the install-state.gz. Can you try deleting these and then running yarn install to see if it reinstalls them? If not, let's keep them removed.
Author
There was a problem hiding this comment.
I'm not quite sure how to delete these from the PR.
… sa/mspca-2-get-volunteer-by-id-and-update-volunteer-by-id
dburkhart07
requested changes
Sep 30, 2026
dburkhart07
left a comment
dburkhart07
left a comment
Collaborator
There was a problem hiding this comment.
all very small things, but looking really good! hopefully should be good to go after these changes!!
dburkhart07
requested changes
Oct 1, 2026
… sa/mspca-2-get-volunteer-by-id-and-update-volunteer-by-id
dburkhart07
approved these changes
Oct 2, 2026
dburkhart07
left a comment
dburkhart07
left a comment
Collaborator
There was a problem hiding this comment.
can you remove the columnName and relationName functions in the plural naming strategy? after that its good so ill approve
shreeyaadhikari
changed the title
shreeyaadhikari
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes MSPCA-2
📝 Description
Adds the ability for foster coordinators to look up a single volunteer's full details by ID and update their info without overwriting the entire record.
Briefly list the changes made to the code:
✔️ Verification
Ran yarn test. All service and controller tests pass for VolunteersService and VolunteersController.
🏕️ (Optional) Future Work / Notes
Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!