fix: make the Biome pre-commit hooks actually work - #84
Merged
Conversation
The Biome hooks passed staged filenames to `bash -lc "..."`, so they landed as positional arguments to bash rather than as arguments to Biome. Biome never saw them and checked the whole `frontend/` tree instead. That pulled in `frontend/public/favicon.svg`, which pre-commit itself excludes, so `biome-lint` failed on every commit regardless of what changed. - Collapses the two hooks into one `biome-check`, because `check --write` already covers format and lint. - Sets `pass_filenames: false`, which is what the hook was doing anyway. - Runs the pinned `frontend/node_modules/.bin` binaries instead of `npx --yes`, so Biome and tsc match the versions in `package.json` rather than whatever the registry serves. - Ignores `public/` in `biome.json` to match the pre-commit exclude, and bumps the schema to the installed 2.5.11.
✅ Deploy Preview for climate-ref ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Warning Review limit reachedNext included review available in 17 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Biome pre-commit hooks, which never received the staged filenames and so checked the whole
frontend/tree on every commit.The hooks passed staged filenames to
bash -lc "...", so they landed as positional arguments to bash rather than as arguments to Biome. That pulled infrontend/public/favicon.svg, which pre-commit itself excludes, sobiome-lintfailed on every commit regardless of what changed.biome-check, becausecheck --writealready covers format and lint.pass_filenames: false, which is what the hook was doing anyway.frontend/node_modules/.binbinaries instead ofnpx --yes, so Biome and tsc match the versions inpackage.jsonrather than whatever the registry serves.public/inbiome.jsonto match the pre-commit exclude, and bumps the schema to the installed 2.5.11.Split out of #82, which carried this fix incidentally.