Skip to content

Accept esm-hist alongside historical in diagnostic data requirements - #893

Draft
lewisjared wants to merge 3 commits into
mainfrom
esm-hist
Draft

Accept esm-hist alongside historical in diagnostic data requirements#893
lewisjared wants to merge 3 commits into
mainfrom
esm-hist

Conversation

@lewisjared

Copy link
Copy Markdown
Contributor

Adds esm-hist to every diagnostic data requirement that currently filters on historical. This is mainly for testing CMIP7, where only esm-hist data has been published so far.

  • Only the solver-side filters change. Test-case download requests still fetch historical sample data.
  • The global warming levels diagnostic keeps requiring historical, because it splices it onto the ssp runs.
  • Diagnostics that group by experiment_id will now run once for each of historical and esm-hist when a model has both.

This is a testing branch and may not be suitable for every diagnostic, so it may not end up merged.

@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
core 93.77% <ø> (ø)
providers 87.70% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...esmvaltool/diagnostics/climate_drivers_for_fire.py 100.00% <ø> (ø)
..._esmvaltool/diagnostics/cloud_radiative_effects.py 100.00% <ø> (ø)
...e_ref_esmvaltool/diagnostics/cloud_scatterplots.py 100.00% <ø> (ø)
...ool/src/climate_ref_esmvaltool/diagnostics/enso.py 92.00% <ø> (ø)
...ol/src/climate_ref_esmvaltool/diagnostics/ozone.py 92.45% <ø> (ø)
...valtool/diagnostics/regional_historical_changes.py 85.15% <ø> (ø)
...e_ref_esmvaltool/diagnostics/sea_ice_area_basic.py 100.00% <ø> (ø)
..._ref_esmvaltool/diagnostics/sea_ice_sensitivity.py 70.49% <ø> (ø)
...ple/src/climate_ref_example/surface_temperature.py 100.00% <ø> (ø)
...limate-ref-ilamb/src/climate_ref_ilamb/standard.py 88.02% <ø> (ø)
... and 3 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant