Floor dependency versions that carry published security advisories - #252
Open
nataliamelissas wants to merge 1 commit into
Open
Floor dependency versions that carry published security advisories#252nataliamelissas wants to merge 1 commit into
nataliamelissas wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mix deps.getondevcurrently reports published advisories against 13 packages. Most of themhave a fix inside the version line the project already allows — resolution just is not required to
pick it, so a fresh
mix deps.getcan still land on the vulnerable version.This raises the floors. No major upgrades:
phoenixstays on 1.7,phoenix_live_viewon 1.0.Postgrex.Notifications.listen/3postgrexis the one that needed its requirement widened rather than floored:~> 0.20.0pins the0.20 line, and the fix is in 0.22.2.
req0.5 to 0.6 is the only change that crosses a minor version. It is used inClaper.Transcriptions.VoxtralClientand the LTI 1.3 modules, all throughReq.get/2,Req.post/2and%Req.Response{}, which are unchanged across that boundary.Two advisories are left after this and neither has a version to move to:
mix test(338 tests),mix credoandmix formatall pass on this branch.