Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The importer can store two narrator credits joined with
+, while the ABS exporter only splits commas and semicolons. The exportednarratorsarray can therefore retain the joined string alongside the individual edition credits.Recognize the existing space-plus-space join delimiter before trimming and case-insensitive deduplication. Add regression coverage for joined credits from the file/edition/book inputs and preserve literal plus signs such as
C++ NarratorandFirst+Second.This changes credit formatting only. It does not choose a different edition, change the underlying source tags, or establish who narrated a particular recording. The regression test exercises the exporter directly; existing untracked sidecars are still protected by the metadata service's ownership rules.
Fixes #361
Database Migration
No.
How was this tested?
On macOS arm64 with .NET SDK
10.0.404, againstdevelopcommit04c1ed1fba2ba08b72ea5e80f85578eaa076ffe3:dotnet test src/Chaptarr.Core.Test/Chaptarr.Core.Test.csproj --filter FullyQualifiedName~AudioBookShelfMetadataFixturegit diff --checkpasses.Screenshots (UI changes only)
N/A.
Summary by CodeRabbit
" + "are now recognized as separate names, while plus signs without that exact spacing remain part of the name.