Repository navigation
Conversation
A ManualImport file without a numeric editionId was rejected with "Edition must be selected for '<title>'.", whether editionId was omitted or the caller sent foreignEditionId instead. foreignEditionId looks like the stable identifier from GET /api/v1/edition, so API callers had no way to tell what was wrong. The message now says editionId is missing and points to GET /api/v1/edition?bookId=<id>. When the file carries a foreignEditionId, it also explains that foreignEditionId is only used for metadata suggestions, and that a book already in the library needs the numeric editionId. Behaviour is unchanged: the file is still rejected. Fixes Chaptarr#108 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GXPbRG8Geef4zMeMQgpQ8H
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A
ManualImportfile without a numericeditionIdwas rejected withEdition must be selected for '<title>'.. The message is the same whethereditionIdwas omitted or the caller sentforeignEditionIdinstead. SinceforeignEditionIdlooks like the stable identifier inGET /api/v1/edition, API callers had no way to tell what was wrong. Fixes #108.Change
ManualEditionSelectionMatchesBooknow produces one of two messages.Without
foreignEditionId:With
foreignEditionIdon the file:Behaviour is unchanged: the file is still rejected.
foreignEditionIdkeeps its existing meaning for metadata suggestions, so this PR doesn't start accepting it for library books. The UI validates the edition itself before sending, so this only affects API callers.Testing
foreignEditionIdcase, including trimming.dotnet test --filter ManualImport: 160 pass.AI disclosure
This PR was written with Claude Code, using Claude Opus 5.5 (
claude-opus-5-5,mediumeffort). I reviewed the change and the test results before submitting.🤖 Generated with Claude Code
https://claude.ai/code/session_01GXPbRG8Geef4zMeMQgpQ8H