Skip to content

fix: remove survey alert + add carto API key - #280

Merged
t-kramer merged 2 commits into
developmentfrom
remove-survey-alert
Oct 1, 2026
Merged

t-kramer merged 2 commits into
developmentfrom
remove-survey-alert

Conversation

@t-kramer

Copy link
Copy Markdown
Contributor

I removed the automatic survey alert coming up after a few seconds.

I guess we don't need it anymore.

@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: b3004a88-704b-4568-82b5-73fdd48e2b4c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@t-kramer

Copy link
Copy Markdown
Contributor Author

@FedericoTartarini @giobetti

You might have noticed the watermark in the deployed app.

Carto now requires an API key for its free raster basemap tiles, which is causing the "API KEY REQUIRED" watermark on Clima's two maps (weather file selector and climate summary).

I made a few changes to adopt the new policy and added the key to Secrets Manager on GCR. Below more details:

  • Added CARTO_API_KEY config, read from the environment (config.py)
  • Added a shared apply_carto_basemap() helper (pages/lib/utils.py) that authenticates Carto's raster tile requests, replacing the old mapbox_style="carto-positron" calls in pages/select.py and pages/lib/charts_summary.py
  • Wired the key into deployment via GCP Secret Manager: cloudbuild.yaml now passes --set-secrets CARTO_API_KEY=carto-api-key:latest to gcloud run deploy, so the key is injected at runtime and never stored in the image, repo, or CI logs
  • Required one-time manual setup (already done): the carto-api-key secret created in Secret Manager, with relevant roles/rights granted to both the Cloud Run runtime service account and the GitHub Actions deploy service account

FYI: Locally, the map falls back to the (watermarked) unauthenticated tiles unless the secret key is exported in the shell. This is pretty easy to do if you want to double check the app before deployment.

@FedericoTartarini Please review this PR, so we can merge into dev and re-deploy asap. Thx! ✌🏼

@t-kramer t-kramer changed the title fix: remove survey alert fix: remove survey alert + add carto API key Sep 29, 2026
@FedericoTartarini
FedericoTartarini requested a balanced review from Copilot September 29, 2026 02:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@t-kramer
t-kramer merged commit c33b79c into development Oct 1, 2026
2 checks passed
@t-kramer
t-kramer deleted the remove-survey-alert branch October 1, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants