Repository navigation
Replace deprecated get_request_var_post() with get_nfilter_request_var() - #43
Merged
somethingwithproof merged 1 commit intoOct 24, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The single-line alias replacement preserves validation and behavior, with no unresolved findings.
No open issues 🎉
What changed in this PR
Replaces a deprecated Cacti request accessor with its canonical equivalent in WMI query action handling, preserving existing behavior.
Changes:
- Replaces
get_request_var_post('drp_action')withget_nfilter_request_var('drp_action'). - Leaves numeric input validation unchanged.
| File | Description |
|---|---|
wmi_queries.php |
Uses the canonical non-filtered request accessor in actions_queries(). |
Review effort: Balanced
bmfmancini
approved these changes
Oct 24, 2026
bmfmancini
approved these changes
Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
get_request_var_post()is a deprecated (v1.0) alias ofget_nfilter_request_var()in Cacti core (lib/html_utility.php) — note it is an alias of the non-filtered accessor, notget_request_var(). This PR replaces the remaining call site with the canonical function so behavior is preserved exactly.Change
get_request_var_post(...)->get_nfilter_request_var(...)Why not get_request_var()?
get_request_var()returns the filtered/validated value, logs a "not first been filtered" warning whenlog_validationis on, and writes back viaset_request_var().get_nfilter_request_var()is the true behavioral equivalent of the deprecatedget_request_var_post()alias.Validation
php -lpasses on changed file(s).