Repository navigation
Refactor Slowlog import stages and bound statistics memory - #63
Merged
somethingwithproof merged 2 commits intoOct 24, 2026
Merged
Conversation
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
somethingwithproof
force-pushed
the
refactor/import-pipeline
branch
from
October 24, 2026 10:27
c22a4e7 to
73ff085
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Imports now report failures to their callers and retain source files when ingestion or post-processing fails. The follow-up separates the streaming parser, batch writer, SQL table extractor, page queries and statistics, while keeping the public helper functions available.
Stacked on #60; this PR targets
fix/review-hardeningso the refactor can be reviewed separately.Validation: 534 tests pass, including the real database and HTTP suite; CI changed-line coverage is 100% (792/792 lines). Real MariaDB regressions verify retained input and nonzero file-import, post-processing and reprocessing failures. PHP syntax, manifest, translation-template and workflow checks pass. CI passes on PHP 8.2, 8.3 and 8.4.
Five-run isolated PHP benchmarks show statistics peak allocation falling from 30 MiB to 14 MiB, with median time falling from 0.498 s to 0.459 s. Ingestion takes about 9% less time and table extraction is essentially unchanged. Database adapters are stubbed; these are not whole-application latency measurements. Reproduction commands and raw results are in
tests/benchmarks/.