Skip to content

Replace deprecated get_request_var_request() with get_request_var() #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TheWitness wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Replace deprecated get_request_var_request() with get_request_var() #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e0b904
Replace deprecated get_request_var_request() with get_request_var()
Oct 23, 2026
fb96020
test: allowlist top_graph_header.php in the patch coverage gate
somethingwithproof Oct 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tests/bin/patch-coverage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,10 @@ function changed_lines($base_ref) {
// plugin_npc_install() at install time, not exercisable in the isolated
// unit process.
'includes/database.php',
// Legacy web header: executes at the top level against the session and
// auth tables, so it cannot be loaded into the isolated unit process. Changed
// here only to replace a deprecated request-variable alias.
'top_graph_header.php',
];
$unmeasured = array_values(array_diff(array_keys($changed), array_keys($measured)));
$unexpected_unmeasured = array_values(array_diff($unmeasured, $unmeasured_allowlist));
Expand Down
2 changes: 1 addition & 1 deletion top_graph_header.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
}

/* ================= input validation ================= */
input_validate_input_number(get_request_var_request("local_graph_id"));
input_validate_input_number(get_request_var("local_graph_id"));
/* ==================================================== */

if (read_config_option("auth_method") != 0) {
Expand Down
Loading