Repository navigation
Fix Midwinter panel contrast and dialog severity colors - #452
Open
somethingwithproof wants to merge 3 commits into
Open
somethingwithproof wants to merge 3 commits into
somethingwithproof wants to merge 3 commits into
Conversation
somethingwithproof
changed the title
somethingwithproof
marked this pull request as ready for review
October 26, 2026 06:47
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
TheWitness
force-pushed
the
fix/midwinter-theme-status-contrast
branch
from
October 26, 2026 14:20
93474bf to
5d3113f
Compare
TheWitness
reviewed
Oct 26, 2026
TheWitness
left a comment
TheWitness
left a comment
Member
There was a problem hiding this comment.
Do thos images really belong in a static directory instead of some transient artifact directory like tests/images?
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
|
Member
Author
|
Moved the browser-generated theme screenshots to tests/images in 69b13d1, updated their documentation links and regeneration path, and restacked the dependent PRs through the native GitHub stack. All 28 browser tests pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Midwinter panel text and row markers lose contrast on dark panel surfaces; bright details dots blend into light titlebars. Its generic dialog icon rule also turns the red alert dot blue when a real jQuery UI dialog opens.
Use readable panel text, palette-specific indicators, and details-dot selectors that preserve severity colors inside the native dialog. Keep panel header colors unchanged.
Fixes #451. Confirmed against develop. This extends the shared alpha/gradient-aware browser tests above the Hollyberry layer in the native theme stack.
Validation: all 28 Chromium browser tests pass locally. Both palettes cover panel text, all status colors on panel-backed odd/even/plain rows, distinct severity colors inside widget styling, and opening/closing populated real dialogs. The original styles fail the new contrast and alert-color assertions. Changed CSS coverage is 100% (29/29 executable added lines).
README and validation docs include populated dashboard/details screenshots for both palettes using synthetic measurements and alerts. These use real core/plugin stylesheets and jQuery UI in browser fixtures, not a live installation.