Repository navigation
Fix Deepness green and red row marker contrast - #448
Open
somethingwithproof wants to merge 1 commit into
Open
somethingwithproof wants to merge 1 commit into
somethingwithproof wants to merge 1 commit into
Conversation
somethingwithproof
changed the title
somethingwithproof
marked this pull request as ready for review
October 26, 2026 05:15
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
TheWitness
force-pushed
the
fix/deepness-theme-status-contrast
branch
from
October 26, 2026 14:20
065ad45 to
317469d
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deepness row markers reuse panel header backgrounds. The translucent green marker measures 1.72:1 contrast against odd rows; red measures 2.78:1. Use an opaque green accent and brighter red for row markers while preserving panel headers and details-dot colors.
Fixes #447. Confirmed against develop. This PR extends the Dark layer's alpha-aware contrast tests and is the next layer in the native theme stack.
Validation: all 16 Chromium browser tests pass, including severity colors on odd/even/page surfaces and opening/closing populated alert details. The original Deepness styles fail the marker contrast assertions. Changed CSS coverage is 100% (4/4 executable added lines).
README and validation docs include populated synthetic monitoring screenshots rendered with the actual core/plugin stylesheets and jQuery UI. These are browser fixtures, not a live installation.