Repository navigation
Update the README to match the code - #78
Merged
Merged
Conversation
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
|
TheWitness
approved these changes
Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Rewrites README.md so that each statement matches the code on origin/develop. INFO and manifest.json are unchanged; no code is touched.
Related Issue
None.
Motivation and Context
The old README had an install paragraph and little else, and parts of it were wrong or missing:
templates/("Stats" against "stats");hmib_enabled), that PHP 8.0 or later is needed, or that the Graphs tab fails on Cacti 1.2.32;New facts the README now states that a reader could not guess: the automation setting is used as a number of days (
poller_graphs.php:101multiplies by 86400, so "1 Hour" is one day); upgrade deletestests/andphpunit.xmlfrom the plugin directory; uninstall keeps the saved settings, the core indexes the plugin added and the imported packages; Rescan can change the type of a device that already has one through the regular expression branch.How Has This Been Tested?
Every claim was checked against origin/develop, either by reading the line or by running the command, in a throwaway Cacti (develop and 1.2.32; 1.2.25 for the install and page checks) with PHP 8.4 in Docker and MariaDB 11.8. Plugin lifecycle used
php cli/plugin_manage.php. Cacti's cacti.log was restored afterwards.php -lon 7.4, 8.0, 8.1plugin_manage.php --install --enable,--disable,--uninstallhmib_enabledis empty--versionand--helpof the three scripts-fdhas no effectlocales/build_gettext.shin Debian bookworm with GNU gettextinclude/cacti_version, which is absent outside a Cacti treevalidate-manifest.php,check-i18n-pot.php origin/develop~1,patch-coverage.phpNot run: PHP 8.2 to 8.4 CI matrix itself, a remote data collector, SNMPv3 devices.
Screenshots (if appropriate):
None.
Types of changes
Checklist: