Skip to content

Replace deprecated get_request_var_request() with get_request_var() - #76

Merged
somethingwithproof merged 1 commit into
developfrom
fix/replace-deprecated-get-request-var
Oct 24, 2026
Merged

somethingwithproof merged 1 commit into
developfrom
fix/replace-deprecated-get-request-var

Conversation

@TheWitness

Copy link
Copy Markdown
Member

Summary

get_request_var_request() is a deprecated (v1.0) alias of get_request_var() in Cacti core (lib/html_utility.php). This PR replaces the remaining call sites with the canonical function. Behavior is unchanged because the alias simply forwards to get_request_var().

Change

  • get_request_var_request(...) -> get_request_var(...)

Validation

  • php -l passes on changed file(s).
  • No remaining deprecated call sites after the change.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 23, 2026 22:39
@sonarqubecloud

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The three direct alias replacements preserve existing behavior, with no unresolved issues identified.

No open issues 🎉

What changed in this PR

Replaces the remaining deprecated request-helper calls in the Host MIB type administration page with Cacti’s canonical get_request_var() helper, preserving behavior.

Changes:

  • Updates three call sites covering ID validation and row-count selection.
  • Leaves arguments and surrounding logic unchanged.
File Description
hmib_types.php Replaces three deprecated helper calls with get_request_var().

Review effort: Balanced

@somethingwithproof
somethingwithproof merged commit 06078a5 into develop Oct 24, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants