Repository navigation
ci: revert meatloaf stale chipStar install workaround - #8
Merged
Merged
Conversation
This reverts commit 01124df. meatloaf's HIP/chipStar/main install was rebuilt from chipStar main e57c54f5, whose generated .hipInfo and hip-targets.cmake resolve the install prefix correctly. The workaround copied hip-targets.cmake into $RUNNER_TEMP, and the new file locates the install relative to itself, so the copy now points at a nonexistent libCHIP.so and CMake configure fails. The job can use the module's hipcc and CMAKE_PREFIX_PATH directly again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
meatloaf's HIP/chipStar/main install was rebuilt from current chipStar main, which writes correct install paths. The workaround from 01124df copies hip-targets.cmake into RUNNER_TEMP, and the new file resolves the install relative to itself, so configure now fails on a missing libCHIP.so. This reverts it.
This PR was generated using AI