feat: NetBox 4.7 compatibility (4.7.0.1) - #10
Merged
Merged
Conversation
- Detect model registration via registry['views'] since registry['models'] was removed in NetBox 4.7 - Iterate registry['plugins']['installed'] instead of settings.PLUGINS so plugins skipped by NetBox for version mismatch do not log tracebacks - Bump version to 4.7.0.1, pins to 4.7.0-4.7.99, Django classifier 6.1 - Update tests, README compatibility matrix, CHANGELOG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NetBox 4.7.0 compatibility, released as 4.7.0.1.
registry['models']was removed in NetBox 4.7, so_is_model_registerednow infers registration fromregistry['views']: a model is registered when every feature viewregister_models()would add for it (per the feature mixins it subclasses) is already present by name.registry['plugins']['installed']instead ofsettings.PLUGINS. NetBox 4.7 skips plugins failingmin_version/max_versionwith a warning; iteratingsettings.PLUGINSproduced "Error resolving plugin" tracebacks for each of them.4.7.0–4.7.99, Django classifier6.1, README matrix row, CHANGELOG.Verification
pytest tests/ -q: 18 passed;ruff check .: cleanmanage.py checkclean, plugin listed inregistry['plugins']['installed'], custom-objects models showjournal/changelogviews exactly once,CustomFieldForm.object_typesrefreshed.