Added generatedAt field to SsvcObjectRegistry - #1241
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new timestamp is currently tied to registry instantiation (singleton) rather than generation/serialization time, and the schema should enforce the RFC 3339 shape via format: date-time.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR adds generation-time metadata to the SSVC object registry so consumers can tell when the registry data was produced.
Changes:
- Added a new
generatedAttimestamp field toSsvcObjectRegistry. - Updated the corresponding JSON Schema to include the new property.
- Regenerated the published
data/json/ssvc_object_registry.jsonto includegeneratedAt.
File summaries
| File | Description |
|---|---|
| src/ssvc/registry/base.py | Introduces the generatedAt field on the registry model (timestamp generation behavior). |
| data/schema/v2/SsvcObjectRegistry_2_0_0.schema.json | Adds generatedAt to the published JSON Schema for registry validation. |
| data/json/ssvc_object_registry.json | Updates the checked-in registry JSON to include the new metadata field. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
ahouseholder
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new timestamp field to the
SsvcObjectRegistryclass to record when the registry was generated. This helps track the creation time of registry data in a standardized format.Enhancement to registry metadata:
generatedAtfield to theSsvcObjectRegistryclass, which automatically sets an RFC 3339-compliant UTC timestamp when the registry is generated.datetimeandtimezonefrom the standard library to support timestamp generation.Attempt to resolve #1219 with a feature that will provide timestamp of the latest release of SSVC objects.