Skip to content

Added generatedAt field to SsvcObjectRegistry - #1241

Merged
sei-vsarvepalli merged 5 commits into
mainfrom
feature/Issue1219
Sep 14, 2026
Merged

sei-vsarvepalli merged 5 commits into
mainfrom
feature/Issue1219

Conversation

@sei-vsarvepalli

Copy link
Copy Markdown
Contributor

This pull request introduces a new timestamp field to the SsvcObjectRegistry class to record when the registry was generated. This helps track the creation time of registry data in a standardized format.

Enhancement to registry metadata:

  • Added a generatedAt field to the SsvcObjectRegistry class, which automatically sets an RFC 3339-compliant UTC timestamp when the registry is generated.
  • Imported datetime and timezone from the standard library to support timestamp generation.

Attempt to resolve #1219 with a feature that will provide timestamp of the latest release of SSVC objects.

Copilot AI lite review requested due to automatic review settings September 9, 2026 15:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new timestamp is currently tied to registry instantiation (singleton) rather than generation/serialization time, and the schema should enforce the RFC 3339 shape via format: date-time.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR adds generation-time metadata to the SSVC object registry so consumers can tell when the registry data was produced.

Changes:

  • Added a new generatedAt timestamp field to SsvcObjectRegistry.
  • Updated the corresponding JSON Schema to include the new property.
  • Regenerated the published data/json/ssvc_object_registry.json to include generatedAt.
File summaries
File Description
src/ssvc/registry/base.py Introduces the generatedAt field on the registry model (timestamp generation behavior).
data/schema/v2/SsvcObjectRegistry_2_0_0.schema.json Adds generatedAt to the published JSON Schema for registry validation.
data/json/ssvc_object_registry.json Updates the checked-in registry JSON to include the new metadata field.
Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/ssvc/registry/base.py
Comment thread data/schema/v2/SsvcObjectRegistry_2_0_0.schema.json
sei-vsarvepalli and others added 3 commits September 9, 2026 11:09
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@sei-vsarvepalli
sei-vsarvepalli merged commit baf51f5 into main Sep 14, 2026
6 checks passed
@sei-vsarvepalli
sei-vsarvepalli deleted the feature/Issue1219 branch September 14, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release date

3 participants