Preserve map entity order - #357
Merged
Merged
Conversation
Vegita2
requested changes
Sep 13, 2026
Vegita2
left a comment
Vegita2
left a comment
Member
There was a problem hiding this comment.
looks good. I remembered having a test case fail because of entity orders and found this line
// TODO: fix map loading, order of entities doesn't matter
Now it probably should say it DOES matter. Tests currently don't work anyway so it's something for the future when we update angular and use vitest.
I also noticed there is a race condition when quickly loading multiple maps which already existed before. Because of the async entity loading the second map can load entities from the first map. Probably out of scope for this pull request but should be kept in mind
Vegita2
approved these changes
Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since entities are generated concurrently, the order at which they are added was indeterminstic. Instead, this waits for all entities to load and then adds all successfully generated entities in the correct order.
This has the downside of not adding any entities if any entity never finishes loading.
I also included a fix for a race condition while I was at it.