Repository navigation
Split the chat controller into a room, its schedule and its roster - #374
Merged
Merged
Conversation
ChatRoom is plain Dart under lib/domain/room; ChatController is now the Riverpod host for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 1600-line ChatController is now a plain-Dart ChatRoom under lib/domain/room, with scheduling in Schedule (ordering policy as two methods on OmadaOrdering), routing and the Omada gate in Roster, and Agent as the turn-taking participant. ChatController shrinks to the Riverpod host that implements TurnDriver and owns titling, failure notifications and auto-compact; the room's notes move with it to lib/domain/room/AGENTS.md. Behaviour is unchanged: the existing controller tests pass as they were, and ChatRoom (over a fake RoomHost), Schedule and Roster get tests of their own.
Sub-agents, per-agent permissions and a Human participant class are left out on purpose: sub-agents run under ApproveMode.never and keep the task out of their transcript, so routing them through the room or narrowing their grants would change behaviour.