Skip to content

removes outdated tests - #240

Open
jamie-at-bunny wants to merge 3 commits into
mainfrom
test/audit-sweep
Open

jamie-at-bunny wants to merge 3 commits into
mainfrom
test/audit-sweep

Conversation

@jamie-at-bunny

Copy link
Copy Markdown
Member

No description provided.

@bunnynet-devops

Copy link
Copy Markdown

@codex review

@changeset-bot

changeset-bot Bot commented Sep 29, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8a1b5c5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-29T11:42:40.223508Z 8a1b5c5 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: 8a1b5c53c0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@greptile-apps

greptile-apps Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 4/5

[Low risk] Removes test cases and makes internal functions private.

The PR has no identified behavioral blocker, but the new fixture-writing code should satisfy the repository instruction before merging.

Fix All in Claude CodeFindings

  1. P2 Synchronous fixture write ▶

Summary

The PR removes redundant tests, tests several helpers through their callers, and makes unused exports private. It also removes an unused REST parser helper. The new environment-file test uses a fixture-writing API that conflicts with the repository’s Bun preference.

Reviews (1) · Last reviewed commit: "test: delete duplicate, probe, and copie..."

describe("collectEnv", () => {
test("entries override the env file", async () => {
const envFile = join(mkdtempSync(join(tmpdir(), "bunny-env-")), ".env");
writeFileSync(envFile, "A=1\nB=2\n");

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Synchronous fixture write The new async test writes its .env fixture with writeFileSync. The repository instructs contributors to prefer Bun file APIs over node:fs writes where applicable. Please use Bun.write here to satisfy that requirement before merging.

Suggested change
writeFileSync(envFile, "A=1\nB=2\n");
await Bun.write(envFile, "A=1\nB=2\n");

Context Used: CLAUDE.md (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Fix in Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants