removes outdated tests - #240
jamie-at-bunny wants to merge 3 commits into
Conversation
|
@codex review |
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
| describe("collectEnv", () => { | ||
| test("entries override the env file", async () => { | ||
| const envFile = join(mkdtempSync(join(tmpdir(), "bunny-env-")), ".env"); | ||
| writeFileSync(envFile, "A=1\nB=2\n"); |
There was a problem hiding this comment.
Synchronous fixture write The new async test writes its
.env fixture with writeFileSync. The repository instructs contributors to prefer Bun file APIs over node:fs writes where applicable. Please use Bun.write here to satisfy that requirement before merging.
| writeFileSync(envFile, "A=1\nB=2\n"); | |
| await Bun.write(envFile, "A=1\nB=2\n"); |
Context Used: CLAUDE.md (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
No description provided.