[amitchone]

Fixes issues associated with various (stricter) compiler flags enabled:

• -Wshadow
• -Wignored-qualifiers
• Removing a suppression of -Wnarrow
• -Wconversion
• -Wzero-as-null-pointer-constant
• -Wextra-semi

Also fixes CMake warnings when the module is included in a west manifest but isn't built for a target.

[garethpotter]

I will have a look at this shortly. Does this compile on both clang and GCC? I have a feeling the narrowing warning was there for one of the compilers.

[amitchone]

This builds for me with clang 16.0.6 and 19.1.7. And of course GCC 12. A wee snippet of the clang-19 build:

user@77b9167b27ce:~/brill-zephyr-workspace/modules/thingset++$ cmake -S tests -B build-clang19 -DCMAKE_C_COMPILER=clang-19 -DCMAKE_CXX_COMPILER=clang++-19
-- The C compiler identification is Clang 19.1.7
-- The CXX compiler identification is Clang 19.1.7
...
-- Configuring done
-- Generating done
-- Build files have been written to: /home/user/brill-zephyr-workspace/modules/thingset++/build-clang19
user@77b9167b27ce:~/brill-zephyr-workspace/modules/thingset++$ cmake --build build-clang19 --target thingset++
[  3%] Building C object thingset++/CMakeFiles/zcbor.dir/zcbor/src/zcbor_common.c.o
...
[100%] Linking CXX shared library libthingset++.so
[100%] Built target thingset++

[garethpotter]

Right, I see the change now (I was on my phone) and the mask is a nice improvement. I think I was confusing it with something else (size of size_t on 64-bit *BSD and macOS, maybe...).

[garethpotter]

What is the reason for this? The field is still const device *const.

[amitchone]

It was flagged by -Wextra because the function is returning a copy of the pointer and so the extra constraint doesn't actually do anything - i.e., the user could do whatever they like with their own copy. But aye, the field itself is still indeed constraint properly

[garethpotter]

Oh I see. Fair enough.

[garethpotter]

Nice.

[garethpotter]

Marvellous.