Repository navigation
Spec 017 phase 6: acceptance — 42 of 42, AC8 and AC11 repaired on your ruling, 299 blocks build - #196
Merged
Merged
Conversation
…half, AC11 The walker's findings, each verdict not yet ruled: AC6's rule-1 reading finds no stubbed type a page tells the reader to write; AC8's second half unmet on three blocks marked // ... where the using could be written; AC11 unmet on 30 of 119 behavioural repaired blocks. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016Am29wrQUS81NVh8dUyNuy
- AC8: using directives where three blocks said // ... ; writing them exposed
[FallbackPolicy(backstop: true, step: 1)] missing its required circuitBreaker (CS7036), x4
- AC11, the thirty claims run with controls against 10.7.0 / Darker 4.1.1. False, and repaired:
Darker's decorator order read backwards (QueryPipeline.md); a backstop's exception flow
and a Polly fallback that cannot reach the handler (PolicyFallback.md); feature switches
with no registry, and DontAckAction's redelivery (FeatureSwitches.md, HandlerFailure.md);
no scheduler said to mean immediate requeue (BrighterSchedulerSupport.md);
CharacterEncoding.Raw said to protect binary bodies (KafkaConfiguration.md,
MessageMappers.md); spans said to need only AddBrighterInstrumentation (Telemetry.md,
ConfiguringOpenTelemetry.md); CreateCopy without Policies; InMemoryOutbox's comment
- Found beside the runs: 15 blocks naming a provider by typeof without registering what
it is built from, on 10 pages; EFCoreOutbox.md's V9 Use{DB}Outbox prose; MongoDB's
OnResolvingACollection.Create and MongoClientSettings.ConnectionString, on two pages
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016Am29wrQUS81NVh8dUyNuy
…UILT Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016Am29wrQUS81NVh8dUyNuy
…rows 2 and 9 at bd95ee0 AC6 accepted by the maintainer. AC8 and AC11 unmet at the walk and repaired under the ruling: the run table, 2.5's three missing cases and controls, ten defect-ledger rows. blockcheck 295 -> 299 BUILT, pagelint 537 -> 524, the other gates unmoved. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016Am29wrQUS81NVh8dUyNuy
--classify is deterministic and agrees with the probe but for 146 parse and 82 import blocks, each explained; seven of the 82 reach import by an extension method's name on another receiver, the Order blind spot again, none on a tranche page. The tranche pages hold 44 FAILED blocks, all listed. Both unit-rule plants exit 1; --list-skips reads 17. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016Am29wrQUS81NVh8dUyNuy
… ledger to 6.5 Walked at f46221d. AC10 is met on the pages. Its ledger has three rows that do not say what the pages now say: #15 and #16 still read "open" though both are repaired, and #100's grep catches a correct use that 6.1 added. They go to 6.5. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016Am29wrQUS81NVh8dUyNuy
…eached by a ledger row, nothing reverted Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016Am29wrQUS81NVh8dUyNuy
#15 and #16 were open rows carried into #82 and #83; each now says so, with their grep. #24 and #61 get asyncscan.py (CS1997, CS4032), #83 and #16 get mapperscan.py, #55 gets its greps, and #100's grep narrows to the key type. Each probe finds its defects at c7329bb and nothing at HEAD. #55's controller grep leaves two off-tranche wrapper shapes, 018's. 6.4's phase 2 Context lines are #7's, not #83's; corrected. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016Am29wrQUS81NVh8dUyNuy
Fourteen entries read from phases 1–6's as-executed sections, each with what 018 should do; recurrences of 53 and 58's family left unnumbered. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016Am29wrQUS81NVh8dUyNuy
…8, built in 018 Twenty-five attr_mismatch.py runs in phases 2–5 as evidence: 7 → 1 at 5.5, never rose. The six repaired blocks are still FAILED, so the baseline risk is latent. Proposal and ruling in tasks.md § For the maintainer: D4; design.md's D4 row records it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016Am29wrQUS81NVh8dUyNuy
What 017 shipped: 101 → 299 BUILT, pages with nothing BUILT 97 → 39, pagelint debt 743 → 524. --classify at e0385b4 puts 630 of the 674 FAILED blocks on the 64 pages no tranche reached. AC8's second half and AC11, repaired under the 2026-09-28 ruling, are re-read in this PR's review; acceptance is the maintainer's. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016Am29wrQUS81NVh8dUyNuy
The maintainer accepted the AC8 and AC11 repairs in #196's review and asked for the CommandProcessorBuilder finding to be filed upstream. Telemetry.md and ConfiguringOpenTelemetry.md link the issue, as #4465's page does. .accepted exists, and the README and tasks.md status lines say ACCEPTED, 42 of 42. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 6 of spec 017 is acceptance. Every criterion has been walked by its command or by the reader it names. The changed pages have been checked for widening, and both ledgers are complete. The spec closes at 42 of 42, with the residual sentence that 018 starts from.
This PR changes the published site, so it needs your sign-off to merge. After the merge, may I delete the head ref
spec/017-phase6?Phase 6 was planned to touch no page. At 6.1, the named readers found AC8's second half and AC11 unmet. You ruled on 2026-09-28 that both be repaired in this PR. As a result,
git diff --name-only origin/master..HEAD -- contentslists 24 pages.For your review: AC8 and AC11 re-read
Both walk rows in
tasks.md§ The acceptance walk still carry 6.1's verdict of unmet. The repairs are in § AC8 and AC11, repaired under the ruling. Re-reading them is this PR's review.AC8. Three blocks were marked
// ...where theusingcould have been written. They now carry theirusings:QueryPipeline.md#8,PolicyFallback.md#3 andHowConfiguringTheCommandProcessorWorks.md#6 (plus #5 beside it). OncePolicyFallback.md#3's attribute resolved, it exposed aCS7036:[FallbackPolicy(backstop: true, step: 1)]omits the requiredcircuitBreaker. All four lines on the page with that defect are repaired.AC11. All thirty blocks that lacked a run with a control have now been run against Brighter 10.7.0 and Darker 4.1.1. Postgres, MySQL, DynamoDB-local and LocalStack ran in Docker. The runs found these claims false or partly false:
QueryPipeline.mdFix typo in title of faq.rst #16's "won't log individual retries" says the reverse of the truth. The prose beside sphinx-ify "Usage Documentation" #1 also recommended the wrong fallback/retry layout.PolicyFallback.md/HandlerFailure.md. Fallback receives the original exception.BrokenCircuitExceptionappears only on later calls.PolicyFallback.mdUpdate documentation #10's Polly fallback did not compile (CS0029,CS1929) and has been rewritten so that the service call runs throughGetPipeline<Product>.FeatureSwitches.md. With no registry,Configis On. A registry that is missing the handler throwsConfigurationException. On the in-memory transport, redelivery happens at once, not after a visibility timeout.InMemoryOutbox.mdUpdate ImplementingAHandler.rst #2.PostAsyncdeposits the message and dispatches it at once.V10MigrationGuide.mdUpdate BuildingAPipeline.rst #12. The page'sCreateCopyomittedPolicies.InMemorySchedulerFactory..Value. The damage comes from a text-column outbox, andbinaryMessagePayload: trueis the repair.Telemetry.md. If tracing is left unset, it behaves asNone. With noAddProducers, there is no Command Processor span at all.Outside the runs: 15 blocks on 10 pages registered a
typeof(...)transaction provider without the configuration it is built from. Each block now registers it. Several MongoDB and EF Core V9 leftovers were repaired too. As a result, 4 MongoDB blocks now build.Open, yours
CommandProcessorBuilderfinding upstream (not yet ruled). In 10.7.0,Build()gives the Command Processor no tracer when there is no external bus (:304). This was run both ways and is stated on both pages..acceptedfile yet. That is yours to add.Gates
linkcheckpagelint--verifyversioncheckoptionchecksymbolcheckblockcheckpagelint --changed origin/masterexits 0.attr_mismatch.pyreads 1, the deliberatePipelineValidation.md:250.What 017 shipped
c7329bb)pagelintusingdebtOver the whole spec, 116 pages changed. The defect ledger has 116 rows, each at 0 after repair. Friction entries 67–80 were added. For D4, you ruled that
attr_mismatchbecomespagelintrule 8, to be built in 018.The residual, the line 018 starts from: 674 of 990 C# blocks still do not compile against the released packages. Of those, 630 are on the 64 pages that 017's tranches never reached: 314 name a pinned type they never import, 145 do not parse, and 113 need a type their page never shows. So 018 first builds
pagelintrule 8 and gives--classifyits second compile, then tranches those 64 pages by what that instrument finds.🤖 Generated with Claude Code