Repository navigation
Use InvalidMessageAction for unmapped message types - #195
Merged
iancooper merged 2 commits intoOct 5, 2026
Merged
Conversation
Member
|
Thanks @AVTUNEY |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several
getRequestTypeexamples throwArgumentExceptionfor an unknown message type. The dispatcher logs and acknowledges that exception, so following the examples can remove the message instead of rejecting it.The examples now use
InvalidMessageAction, as suggested in the issue. This covers the two routing pages and the copies in the FAQ, migration guide, CloudEvents and Agreement Dispatcher pages. The body-routing example also handles malformed JSON and missing or invalid type fields explicitly. The error-handling text now explains that the rejection destination depends on the transport and configuration.I also fixed the imports and small compilation issues in the examples being changed, including the SQS queue-attributes argument. This is a documentation-only change; Brighter's runtime behavior is unchanged.
Validation:
Fixes BrighterCommand/Brighter#4499