Skip to content

Change interface for Arguments and Witness (#UserGeneratedProgram + ProgramInput) - #152

Open
ikripaka wants to merge 3 commits into
devfrom
feat/box-to-into
Open

ikripaka wants to merge 3 commits into
devfrom
feat/box-to-into

Conversation

@ikripaka

@ikripaka ikripaka commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator
  • This PR suggests a bug fix and I've added the necessary tests.
  • This PR introduces a new feature and I've discussed the update in an Issue or with the team.
  • This PR is just a minor change like a typo fix.

  • Change interface for Arguments and Witness

    • In UserProgram::new from &impl ArgumentsTrait -> impl Into<simplex::simplicityhl::Arguments>
    • In #UserGeneratedProgram from ProgramInput::new from Box<dyn WitnessTrait> -> impl Into<WitnessValues>
  • Typos fix

  • Add generated macros input into the ui tests (we require it later, because we can't expand code by local simplex inline)

* UserProgram::new
- from &impl ArgumentsTrait -> impl Into<simplex::simplicityhl::Arguments>
* ProgramInput::new from Box<dyn WitnessTrait> -> impl Into<WitnessValues>
* add default value in UTXO
* add debug implementation for ProgramInput, FinalInput
* add Clone for user generated Program by a macro
@ikripaka ikripaka self-assigned this Sep 16, 2026
@ikripaka ikripaka changed the title refactor: change interface for Arguments and Witness (#UserGeneratedProgram + ProgramInput) Change interface for Arguments and Witness (#UserGeneratedProgram + ProgramInput) Sep 16, 2026
@ikripaka
ikripaka marked this pull request as ready for review September 16, 2026 10:45
@ikripaka
ikripaka requested a review from Arvolear as a code owner September 16, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant